Changeset 23250 in vbox for trunk

Timestamp:

Sep 23, 2009 10:00:46 AM (15 years ago)

Author:

vboxsync

Message:

Deal with dirty page tracking and monitored pages.

Location:

trunk/src/VBox/VMM/VMMAll

Files:

• PGMAllBth.h (modified) (6 diffs)
• PGMAllPool.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/VMMAll/PGMAllBth.h

@@ -2250 +2250 @@
                     PGM_INVL_BIG_PG(pVCpu, GCPtrPage);
                     STAM_PROFILE_STOP(&pVCpu->pgm.s.CTX_MID_Z(Stat,DirtyBitTracking), a);
-                    return VINF_PGM_HANDLED_DIRTY_BIT_FAULT;
+                    return VINF_PGM_HANDLED_DIRTY_BIT_FAULT;    /* restarts the instruction. */
                 }
 # ifdef IN_RING0
@@ -2272 +2272 @@
 
                             STAM_PROFILE_STOP(&pVCpu->pgm.s.CTX_MID_Z(Stat,DirtyBitTracking), a);
-                            return VINF_PGM_HANDLED_DIRTY_BIT_FAULT;
+                            return VINF_PGM_HANDLED_DIRTY_BIT_FAULT;    /* restarts the instruction. */
                         }
                     }
@@ -2369 +2369 @@
                         if (pPteDst->u & PGM_PTFLAGS_TRACK_DIRTY)
                         {
+                            PPGMPAGE pPage = pgmPhysGetPage(&pVM->pgm.s, pPteSrc->u & GST_PTE_PG_MASK);
+
                             LogFlow(("DIRTY page trap addr=%RGv\n", GCPtrPage));
-#  ifdef VBOX_STRICT
-                            PPGMPAGE pPage = pgmPhysGetPage(&pVM->pgm.s, pPteSrc->u & GST_PTE_PG_MASK);
-                            if (pPage)
-                                AssertMsg(!PGM_PAGE_HAS_ACTIVE_HANDLERS(pPage),
-                                        ("Unexpected dirty bit tracking on monitored page %RGv (phys %RGp)!!!!!!\n", GCPtrPage, pPteSrc->u & X86_PTE_PAE_PG_MASK));
-#  endif
+
                             STAM_COUNTER_INC(&pVCpu->pgm.s.CTX_MID_Z(Stat,DirtyPageTrap));
 
@@ -2383 +2380 @@
                              *       fault again and take this path to only invalidate the entry.
                              */
-                            pPteDst->n.u1Write    = 1;
+                            if (    pPage
+                                &&  PGM_PAGE_HAS_ACTIVE_HANDLERS(pPage))
+                            {
+                                /* Assuming write handlers here as the PTE is present (otherwise it wouldn't be). */
+                                pPteDst->n.u1Write    = 0;
+                            }
+                            else
+                                pPteDst->n.u1Write    = 1;
+
                             pPteDst->n.u1Dirty    = 1;
                             pPteDst->n.u1Accessed = 1;
@@ -2390 +2395 @@
 
                             STAM_PROFILE_STOP(&pVCpu->pgm.s.CTX_MID_Z(Stat,DirtyBitTracking), a);
-                            return VINF_PGM_HANDLED_DIRTY_BIT_FAULT;
+                            return VINF_PGM_HANDLED_DIRTY_BIT_FAULT;    /* restarts the instruction. */
                         }
 # ifdef IN_RING0
@@ -2404 +2409 @@
 
                             STAM_PROFILE_STOP(&pVCpu->pgm.s.CTX_MID_Z(Stat,DirtyBitTracking), a);
-                            return VINF_PGM_HANDLED_DIRTY_BIT_FAULT;
+                            return VINF_PGM_HANDLED_DIRTY_BIT_FAULT;    /* restarts the instruction. */
                         }
 # endif

trunk/src/VBox/VMM/VMMAll/PGMAllPool.cpp

@@ -3197 +3197 @@
                     Log4(("pgmPoolTrackFlushGCPhysPTs: i=%d pte=%RX32 cRefs=%#x\n", i, pPT->a[i], cRefs));
                     pPT->a[i].u = (pPT->a[i].u & u32AndMask) | u32OrMask;
+                    if (pPT->a[i].u & PGM_PTFLAGS_TRACK_DIRTY)
+                        pPT->a[i].n.u1Write = 0;    /* need to disallow writes when dirty bit tracking is still active. */
+
                     cRefs--;
                     if (!cRefs)
@@ -3257 +3260 @@
                     Log4(("pgmPoolTrackFlushGCPhysPTs: i=%d pte=%RX64 cRefs=%#x\n", i, pPT->a[i], cRefs));
                     pPT->a[i].u = (pPT->a[i].u & u64AndMask) | u64OrMask;
+                    if (pPT->a[i].u & PGM_PTFLAGS_TRACK_DIRTY)
+                        pPT->a[i].n.u1Write = 0;    /* need to disallow writes when dirty bit tracking is still active. */
+
                     cRefs--;
                     if (!cRefs)