Changeset 23301 in vbox

Timestamp:

Sep 24, 2009 4:59:13 PM (15 years ago)

Author:

vboxsync

Message:

VBoxNetFlt-solaris.c: be bolder in the claims wrt pCred/g_pVBoxNetFltSolarisCred.

File:

• trunk/src/VBox/HostDrivers/VBoxNetFlt/solaris/VBoxNetFlt-solaris.c (modified) (2 diffs)

trunk/src/VBox/HostDrivers/VBoxNetFlt/solaris/VBoxNetFlt-solaris.c

@@ -660 +660 @@
 
     /*
-     * Check kernel credentials.
-     * Protects us to a minor degree, is someone uses kcred besides us, this check is not sufficient.
+     * Check that the request was initiated by our code.
+     *
+     * This ASSUMES that crdup() will return a copy with a unique address and
+     * not do any kind of clever pooling.  This check will when combined with
+     * g_VBoxNetFltSolarisMtx prevent races and that the instance gets
+     * associated with the wrong streams.
      */
     if (pCred != g_pVBoxNetFltSolarisCred)
@@ -2073 +2077 @@
                                 rc = RTSemFastMutexRequest(g_VBoxNetFltSolarisMtx);
                                 AssertRCReturn(rc, rc);
-                                
+
                                 if (fAttach)
                                 {