Changeset 23403 in vbox for trunk/src/VBox/GuestHost/OpenGL/state_tracker

Timestamp:

Sep 29, 2009 9:55:43 AM (15 years ago)

Author:

vboxsync

Message:

crOpenGL: fix uniform location isn't uint and fix array uniforms caching for linux/nvidia combo

File:

• trunk/src/VBox/GuestHost/OpenGL/state_tracker/state_glsl.c (modified) (5 diffs)

trunk/src/VBox/GuestHost/OpenGL/state_tracker/state_glsl.c

@@ -738 +738 @@
         }
         pProgram->pUniforms[i].data = NULL;
-        pProgram->pUniforms[i].location = ((GLuint*)pCurrent)[0];
-        pCurrent += sizeof(GLuint);
+        pProgram->pUniforms[i].location = ((GLint*)pCurrent)[0];
+        pCurrent += sizeof(GLint);
         cbName = ((GLsizei*)pCurrent)[0];
         pCurrent += sizeof(GLsizei);
@@ -762 +762 @@
 }
 #else
+static GLboolean crStateGLSLProgramCacheOneUniform(GLuint location, GLsizei cbName, GLchar *pName, 
+                                                   char **pCurrent, GLsizei *pcbWritten, GLsizei maxcbData)
+{
+    *pcbWritten += sizeof(GLint)+sizeof(GLsizei)+cbName;
+    if (*pcbWritten>maxcbData)
+    {
+        crWarning("crStateGLSLProgramCacheUniforms: buffer too small");
+        crFree(pName);
+        return GL_FALSE;
+    }
+
+    crDebug("crStateGLSLProgramCacheUniforms: uniform[%i]=%s.", location, pName);
+
+    ((GLint*)*pCurrent)[0] = location;
+    *pCurrent += sizeof(GLint);
+    ((GLsizei*)*pCurrent)[0] = cbName;
+    *pCurrent += sizeof(GLsizei);
+    crMemcpy(*pCurrent, pName, cbName);
+    *pCurrent += cbName;
+
+    return GL_TRUE;
+}
+
 DECLEXPORT(void) STATE_APIENTRY 
 crStateGLSLProgramCacheUniforms(GLuint program, GLsizei maxcbData, GLsizei *cbData, GLvoid *pData)
@@ -795 +818 @@
     if (activeUniforms>0)
     {
-        /*+8 to make sure our array uniforms with higher indices will fit in as well*/
+        /*+8 to make sure our array uniforms with higher indices and [] will fit in as well*/
         GLchar *name = (GLchar *) crAlloc(maxUniformLen+8);
         GLenum type;
         GLint size;
         GLsizei cbName;
-        GLuint location;
+        GLint location;
 
         if (!name)
@@ -813 +836 @@
             location = diff_api.GetUniformLocation(pProgram->hwid, name);
 
-            cbWritten += sizeof(GLuint)+sizeof(GLsizei)+cbName;
-            if (cbWritten>maxcbData)
-            {
-                crWarning("crStateGLSLProgramCacheUniforms: buffer too small");
-                crFree(name);
+            if (!crStateGLSLProgramCacheOneUniform(location, cbName, name, &pCurrent, &cbWritten, maxcbData))
                 return;
-            }
-
-            crDebug("crStateGLSLProgramCacheUniforms: uniform[%i]=%d, %s. size=%i", i, location, name, size);
-
-            ((GLuint*)pCurrent)[0] = location;
-            pCurrent += sizeof(GLuint);
-            ((GLsizei*)pCurrent)[0] = cbName;
-            pCurrent += sizeof(GLsizei);
-            crMemcpy(pCurrent, name, cbName);
-            pCurrent += cbName;
 
             /* Only one active uniform variable will be reported for a uniform array by glGetActiveUniform,
@@ -836 +845 @@
             {
                 char *pIndexStr = crStrchr(name, '[');
-                fakeUniformsCount += size-1;
-                
-
+                GLint firstIndex=1;
+                fakeUniformsCount += size;
+
+                crDebug("crStateGLSLProgramCacheUniforms: expanding array uniform, size=%i", size);
+
+                /*For array uniforms it's valid to query location of 1st element as both uniform and uniform[0].
+                 *The name returned by glGetActiveUniform is driver dependant,
+                 *atleast it's with [0] on win/ati and without [0] on linux/nvidia.
+                 */                
                 if (!pIndexStr)
                 {
-                    crWarning("Array uniform name %s doesn't contain [!?", name);
+                    pIndexStr = name+cbName;
+                    firstIndex=0;
                 }
                 else
                 {
-                    for (j=1; j<size; ++j)
-                    {
-                        sprintf(pIndexStr, "[%i]", j);
-                        cbName = crStrlen(name);
-
-                        location = diff_api.GetUniformLocation(pProgram->hwid, name);
-                        crDebug("crStateGLSLProgramCacheUniforms: uniform[%i].[%i]=%d, %s", i, j, location, name);
-
-                        cbWritten += sizeof(GLuint)+sizeof(GLsizei)+cbName;
-                        if (cbWritten>maxcbData)
-                        {
-                            crWarning("crStateGLSLProgramCacheUniforms: buffer too small");
-                            crFree(name);
-                            return;
-                        }
-
-                        ((GLuint*)pCurrent)[0] = location;
-                        pCurrent += sizeof(GLuint);
-                        ((GLsizei*)pCurrent)[0] = cbName;
-                        pCurrent += sizeof(GLsizei);
-                        crMemcpy(pCurrent, name, cbName);
-                        pCurrent += cbName;
-                    }
+                    cbName = pIndexStr-name;
+                    if (!crStateGLSLProgramCacheOneUniform(location, cbName, name, &pCurrent, &cbWritten, maxcbData))
+                        return;
+                }
+
+                for (j=firstIndex; j<size; ++j)
+                {
+                    sprintf(pIndexStr, "[%i]", j);
+                    cbName = crStrlen(name);
+
+                    location = diff_api.GetUniformLocation(pProgram->hwid, name);
+
+                    if (!crStateGLSLProgramCacheOneUniform(location, cbName, name, &pCurrent, &cbWritten, maxcbData))
+                        return;
                 }
             }