Changeset 23485 in vbox for trunk/src

Timestamp:

Oct 1, 2009 2:14:29 PM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

53107

Message:

PGMPAGE: Optimized tests accessing both u2HandlerPhysStateY and u2HandlerVirtStateY. (saving ~2KB on linux/amd64)

Location:

trunk/src/VBox/VMM

Files:

• PGMInternal.h (modified) (5 diffs)
• VMMAll/PGMAllBth.h (modified) (1 diff)

trunk/src/VBox/VMM/PGMInternal.h

@@ -854 +854 @@
 
 
-/** @name Physical Access Handler State values (PGMPAGE::uHandlerPhysStateY).
+/** Enabled optimized access handler tests.
+ * These optimizations makes ASSUMPTIONS about the state values and the u16MiscY
+ * layout.  When enabled, the compiler should normally generate more compact
+ * code.
+ */
+#define PGM_PAGE_WITH_OPTIMIZED_HANDLER_ACCESS 1
+
+/** @name Physical Access Handler State values (PGMPAGE::u2HandlerPhysStateY).
  *
  * @remarks The values are assigned in order of priority, so we can calculate
@@ -952 +959 @@
 
 
-
 /**
  * Checks if the page has any access handlers, including temporarily disabled ones.
@@ -958 +964 @@
  * @param   pPage       Pointer to the physical guest page tracking structure.
  */
-#define PGM_PAGE_HAS_ANY_HANDLERS(pPage) \
+#ifdef PGM_PAGE_WITH_OPTIMIZED_HANDLER_ACCESS
+# define PGM_PAGE_HAS_ANY_HANDLERS(pPage) \
+    ( ((pPage)->u16MiscY.u & UINT16_C(0x0303)) != 0 )
+#else
+# define PGM_PAGE_HAS_ANY_HANDLERS(pPage) \
     (   PGM_PAGE_GET_HNDL_PHYS_STATE(pPage) != PGM_PAGE_HNDL_PHYS_STATE_NONE \
      || PGM_PAGE_GET_HNDL_VIRT_STATE(pPage) != PGM_PAGE_HNDL_VIRT_STATE_NONE )
+#endif
 
 /**
@@ -967 +978 @@
  * @param   pPage       Pointer to the physical guest page tracking structure.
  */
-#define PGM_PAGE_HAS_ACTIVE_HANDLERS(pPage) \
+#ifdef PGM_PAGE_WITH_OPTIMIZED_HANDLER_ACCESS
+# define PGM_PAGE_HAS_ACTIVE_HANDLERS(pPage) \
+    ( ((pPage)->u16MiscY.u & UINT16_C(0x0202)) != 0 )
+#else
+# define PGM_PAGE_HAS_ACTIVE_HANDLERS(pPage) \
     (   PGM_PAGE_GET_HNDL_PHYS_STATE(pPage) >= PGM_PAGE_HNDL_PHYS_STATE_WRITE \
      || PGM_PAGE_GET_HNDL_VIRT_STATE(pPage) >= PGM_PAGE_HNDL_VIRT_STATE_WRITE )
+#endif
 
 /**
@@ -976 +992 @@
  * @param   pPage       Pointer to the physical guest page tracking structure.
  */
-#define PGM_PAGE_HAS_ACTIVE_ALL_HANDLERS(pPage) \
+#ifdef PGM_PAGE_WITH_OPTIMIZED_HANDLER_ACCESS
+# define PGM_PAGE_HAS_ACTIVE_ALL_HANDLERS(pPage) \
+    (   ( ((pPage)->u16MiscY.au8[0] | (pPage)->u16MiscY.au8[1]) & UINT8_C(0x3) ) \
+     == PGM_PAGE_HNDL_PHYS_STATE_ALL )
+#else
+# define PGM_PAGE_HAS_ACTIVE_ALL_HANDLERS(pPage) \
     (   PGM_PAGE_GET_HNDL_PHYS_STATE(pPage) == PGM_PAGE_HNDL_PHYS_STATE_ALL \
      || PGM_PAGE_GET_HNDL_VIRT_STATE(pPage) == PGM_PAGE_HNDL_VIRT_STATE_ALL )
+#endif
 
 

trunk/src/VBox/VMM/VMMAll/PGMAllBth.h

@@ -393 +393 @@
             if (RT_SUCCESS(rc)) /** just handle the failure immediate (it returns) and make things easier to read. */
             {
-                if (   PGM_PAGE_HAS_ACTIVE_PHYSICAL_HANDLERS(pPage)
-                    || PGM_PAGE_HAS_ACTIVE_VIRTUAL_HANDLERS(pPage))
+                if (PGM_PAGE_HAS_ACTIVE_HANDLERS(pPage))
                 {
                     if (PGM_PAGE_HAS_ANY_PHYSICAL_HANDLERS(pPage))