Changeset 23591 in vbox

Timestamp:

Oct 7, 2009 7:57:15 AM (16 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

53257

Message:

Main/MediumImpl: fix closing of DVD/floppy media.

Location:

trunk/src/VBox/Main

Files:

• MediumImpl.cpp (modified) (13 diffs)
• include/MediumImpl.h (modified) (1 diff)

trunk/src/VBox/Main/MediumImpl.cpp

@@ -95 +95 @@
           accessibleInLock(false),
           type(MediumType_Normal),
+          devType(DeviceType_HardDisk),
           logicalSize(0),
           hddOpenMode(OpenReadWrite),
@@ -128 +129 @@
 
     MediumType_T type;
+    DeviceType_T devType;
     uint64_t logicalSize;   /*< In MBytes. */
 
@@ -1047 +1049 @@
  * @param aVirtualBox   VirtualBox object.
  * @param aParent       Parent medium disk or NULL for a root (base) medium.
- * @param aType         Device type of the medium.
+ * @param aDeviceType   Device type of the medium.
  * @param aNode         Configuration settings.
  *
@@ -1054 +1056 @@
 HRESULT Medium::init(VirtualBox *aVirtualBox,
                      Medium *aParent,
-                     DeviceType_T aType,
+                     DeviceType_T aDeviceType,
                      const settings::Medium &data)
 {
@@ -1098 +1100 @@
 
     /* required */
-    if (aType == DeviceType_HardDisk)
+    if (aDeviceType == DeviceType_HardDisk)
     {
         AssertReturn(!data.strFormat.isEmpty(), E_FAIL);
@@ -1137 +1139 @@
     CheckComRCReturnRC(rc);
 
-    if (aType == DeviceType_HardDisk)
+    if (aDeviceType == DeviceType_HardDisk)
     {
         /* type is only for base hard disks */
@@ -1145 +1147 @@
     else
         m->type = MediumType_Writethrough;
+
+    /* remember device type for correct unregistering later */
+    m->devType = aDeviceType;
 
     LogFlowThisFunc(("m->locationFull='%ls', m->format=%ls, m->id={%RTuuid}\n",
@@ -1166 +1171 @@
         rc = pHD->init(aVirtualBox,
                        this,            // parent
-                       aType,
+                       aDeviceType,
                        m);              // child data
         CheckComRCBreakRC(rc);
@@ -1190 +1195 @@
  *
  * @param aVirtualBox   VirtualBox object.
- * @param aType         Device type of the medium.
+ * @param aDeviceType   Device type of the medium.
  * @param aLocation     Location of the host drive.
  * @param aDescription  Comment for this host drive.
@@ -1197 +1202 @@
  */
 HRESULT Medium::init(VirtualBox *aVirtualBox,
-                     DeviceType_T aType,
+                     DeviceType_T aDeviceType,
                      CBSTR aLocation,
                      CBSTR aDescription)
 {
-    ComAssertRet(aType == DeviceType_DVD || aType == DeviceType_Floppy, E_INVALIDARG);
+    ComAssertRet(aDeviceType == DeviceType_DVD || aDeviceType == DeviceType_Floppy, E_INVALIDARG);
     ComAssertRet(aLocation, E_INVALIDARG);
 
@@ -1215 +1220 @@
     RTUUID uuid;
     RTUuidClear(&uuid);
-    if (aType == DeviceType_DVD)
+    if (aDeviceType == DeviceType_DVD)
         memcpy(&uuid.au8[0], "DVD", 3);
     else
@@ -1229 +1234 @@
 
     m->type = MediumType_Writethrough;
+    m->devType = aDeviceType;
     m->state = MediumState_Created;
     m->hostDrive = true;
@@ -4690 +4696 @@
     }
 
-    HRESULT rc = mVirtualBox->unregisterHardDisk(this);
+    HRESULT rc = E_FAIL;
+    switch (m->devType)
+    {
+        case DeviceType_DVD:
+            rc = mVirtualBox->unregisterDVDImage(this);
+            break;
+        case DeviceType_Floppy:
+            rc = mVirtualBox->unregisterFloppyImage(this);
+            break;
+        case DeviceType_HardDisk:
+            rc = mVirtualBox->unregisterHardDisk(this);
+            break;
+        default:
+            break;
+    }
 
     if (FAILED(rc))

trunk/src/VBox/Main/include/MediumImpl.h

@@ -88 +88 @@
     HRESULT init(VirtualBox *aVirtualBox,
                  Medium *aParent,
-                 DeviceType_T aType,
+                 DeviceType_T aDeviceType,
                  const settings::Medium &data);
     // initializer for host floppy/DVD
     HRESULT init(VirtualBox *aVirtualBox,
-                 DeviceType_T aType,
+                 DeviceType_T aDeviceType,
                  CBSTR aLocation,
                  CBSTR aDescription = NULL);