Changeset 23753 in vbox

Timestamp:

Oct 14, 2009 10:15:42 AM (15 years ago)

Author:

vboxsync

Message:

SSM: Missing input checks (using ssmR3DataWrite/Read now).

File:

• trunk/src/VBox/VMM/SSM.cpp (modified) (4 diffs)

trunk/src/VBox/VMM/SSM.cpp

@@ -3153 +3153 @@
 VMMR3DECL(int) SSMR3PutStruct(PSSMHANDLE pSSM, const void *pvStruct, PCSSMFIELD paFields)
 {
+    SSM_ASSERT_WRITEABLE_RET(pSSM);
+    SSM_CHECK_CANCELLED_RET(pSSM);
+    AssertPtr(pvStruct);
+    AssertPtr(paFields);
+
     /* begin marker. */
     int rc = SSMR3PutU32(pSSM, SSMR3STRUCT_BEGIN);
@@ -3214 +3219 @@
      * Validation.
      */
+    SSM_ASSERT_WRITEABLE_RET(pSSM);
+    SSM_CHECK_CANCELLED_RET(pSSM);
     AssertMsgReturn(!(fFlags & ~SSMSTRUCT_FLAGS_VALID_MASK), ("%#x\n", fFlags), VERR_INVALID_PARAMETER);
     AssertPtr(pvStruct);
@@ -5641 +5648 @@
 VMMR3DECL(int) SSMR3GetStruct(PSSMHANDLE pSSM, void *pvStruct, PCSSMFIELD paFields)
 {
+    SSM_ASSERT_READABLE_RET(pSSM);
+    SSM_CHECK_CANCELLED_RET(pSSM);
+    AssertPtr(pvStruct);
+    AssertPtr(paFields);
+
     /* begin marker. */
     uint32_t u32Magic;
@@ -5708 +5720 @@
      * Validation.
      */
+    SSM_ASSERT_READABLE_RET(pSSM);
+    SSM_CHECK_CANCELLED_RET(pSSM);
     AssertMsgReturn(!(fFlags & ~SSMSTRUCT_FLAGS_VALID_MASK), ("%#x\n", fFlags), VERR_INVALID_PARAMETER);
     AssertPtr(pvStruct);
     AssertPtr(paFields);
-
 
     /*