Changeset 238 in vbox for trunk/src

Timestamp:

Jan 23, 2007 1:33:33 PM (18 years ago)

Author:

vboxsync

Message:

Keep the framebuffer locked during resizing

Location:

trunk/src/VBox

Files:

trunk/src/VBox/Frontends/VBoxBFE/DisplayImpl.cpp

-              r146
+              r238
+    {
         LogFlow(("VMDisplay::handleDisplayResize: external framebuffer wants us to wait!\n"));
+        /* Note: The previously obtained framebuffer lock must be preserved.
+         *       The EMT keeps the framebuffer lock until the resize process completes.
+         */
         /// @todo is this compatible with VBOX_NEXT_STEP?
         // the framebuffer needs more time to process
         // the event so we have to halt the VM until it's done
         RTSemEventMultiReset(mResizeSem);
-        mFramebuffer->Unlock();
         RTSemEventMultiWait(mResizeSem, RT_INDEFINITE_WAIT);
-        mFramebuffer->Lock();
+    }

-              r1
+              r238
         LogFlowFunc (("External framebuffer wants us to wait!\n"));
+        /* Note: The previously obtained framebuffer lock is preserved.
+         *       The EMT keeps the lock until the resize process completes.
+         */
         /* The framebuffer needs more time to process
          * the event so we have to halt the VM until it's done.
          */
         RTSemEventMultiReset(mResizeSem);
-        mFramebuffer->Unlock();
         RTSemEventMultiWait(mResizeSem, RT_INDEFINITE_WAIT); /** @todo r=bird: this is a serious deadlock point, where EMT is stuck while the main thread is doing VMR3Req for some reason. */
-        mFramebuffer->Lock();
+    }
+}
 …
                 "for external framebuffers"));
-    mFramebuffer->Lock();
     /* signal our semaphore */
     RTSemEventMultiSignal(mResizeSem);
-    mFramebuffer->Unlock();
     return S_OK;

r235	r238
5501	5501	The caller checks if the call was successful
5502	5502	via IFramebuffer property 'PixelFormat'.
	5503
	5504	Note: The method is called by IDisplay under the Framebuffer lock.
5503	5505	</desc>
5504	5506	<param name="pixelFormat" type="FramebufferPixelFormat" dir="in">

Note: See TracChangeset for help on using the changeset viewer.