Changeset 23882 in vbox

Timestamp:

Oct 19, 2009 6:36:03 PM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

53663

Message:

Main: make restoreSnapshot() work better, adjust VBoxManage

Location:

trunk/src/VBox

Files:

• Frontends/VBoxManage/VBoxManage.h (modified) (1 diff)
• Frontends/VBoxManage/VBoxManageHelp.cpp (modified) (1 diff)
• Frontends/VBoxManage/VBoxManageInfo.cpp (modified) (4 diffs)
• Frontends/VBoxManage/VBoxManageSnapshot.cpp (modified) (5 diffs)
• Main/MachineImpl.cpp (modified) (4 diffs)
• Main/include/MachineImpl.h (modified) (1 diff)

trunk/src/VBox/Frontends/VBoxManage/VBoxManage.h

@@ -169 +169 @@
 
 /* VBoxManageVMInfo.cpp */
-void showSnapshots(ComPtr<ISnapshot> rootSnapshot, VMINFO_DETAILS details, const com::Bstr &prefix = "", int level = 0);
+void showSnapshots(ComPtr<ISnapshot> &rootSnapshot,
+                   ComPtr<ISnapshot> &currentSnapshot,
+                   VMINFO_DETAILS details,
+                   const com::Bstr &prefix = "",
+                   int level = 0);
 int handleShowVMInfo(HandlerArg *a);
 HRESULT showVMInfo(ComPtr<IVirtualBox> virtualBox,

trunk/src/VBox/Frontends/VBoxManage/VBoxManageHelp.cpp

@@ -327 +327 @@
         RTPrintf("VBoxManage snapshot         <uuid>|<name>\n"
                  "                            take <name> [--description <desc>] [--pause] |\n"
-                 "                            discard <uuid>|<name> |\n"
-                 "                            discardcurrent --state|--all |\n"
+                 "                            delete <uuid>|<name> |\n"
+                 "                            restore <uuid>|<name> |\n"
                  "                            edit <uuid>|<name>|--current\n"
                  "                                 [--name <name>]\n"

trunk/src/VBox/Frontends/VBoxManage/VBoxManageInfo.cpp

@@ -48 +48 @@
 ///////////////////////////////////////////////////////////////////////////////
 
-void showSnapshots(ComPtr<ISnapshot> rootSnapshot, VMINFO_DETAILS details, const Bstr &prefix /* = ""*/, int level /*= 0*/)
+void showSnapshots(ComPtr<ISnapshot> &rootSnapshot,
+                   ComPtr<ISnapshot> &currentSnapshot,
+                   VMINFO_DETAILS details,
+                   const Bstr &prefix /* = ""*/,
+                   int level /*= 0*/)
 {
     /* start with the root */
@@ -64 +68 @@
     {
         /* print with indentation */
-        RTPrintf("   %lSName: %lS (UUID: %s)\n", prefix.raw(), name.raw(), Utf8Str(uuid).raw());
+        bool fCurrent = (rootSnapshot == currentSnapshot);
+        RTPrintf("   %lSName: %lS (UUID: %s)%s\n",
+                 prefix.raw(),
+                 name.raw(),
+                 Utf8Str(uuid).raw(),
+                 (fCurrent) ? " *" : "");
     }
 
@@ -81 +90 @@
                     newPrefix = Utf8StrFmt("%lS-%d", prefix.raw(), index + 1);
                 else
+                {
                     newPrefix = Utf8StrFmt("%lS   ", prefix.raw());
+                }
+
                 /* recursive call */
-                showSnapshots(snapshot, details, newPrefix, level + 1);
+                showSnapshots(snapshot, currentSnapshot, details, newPrefix, level + 1);
             }
         }
@@ -1832 +1844 @@
     if (SUCCEEDED(rc) && snapshot)
     {
-        if (details != VMINFO_MACHINEREADABLE)
-            RTPrintf("Snapshots:\n\n");
-        showSnapshots(snapshot, details);
+        ComPtr<ISnapshot> currentSnapshot;
+        rc = machine->GetCurrentSnapshot(currentSnapshot.asOutParam());
+        if (SUCCEEDED(rc))
+        {
+            if (details != VMINFO_MACHINEREADABLE)
+                RTPrintf("Snapshots:\n\n");
+            showSnapshots(snapshot, currentSnapshot, details);
+        }
     }
 

trunk/src/VBox/Frontends/VBoxManage/VBoxManageSnapshot.cpp

@@ -68 +68 @@
 
         /* switch based on the command */
+        bool fDelete = false, fRestore = false;
         if (!strcmp(a->argv[1], "take"))
         {
@@ -154 +155 @@
             }
         }
-        else if (!strcmp(a->argv[1], "discard"))
+        else if (    (fDelete = !strcmp(a->argv[1], "delete"))
+                  || (fRestore = !strcmp(a->argv[1], "restore"))
+                )
         {
             /* exactly one parameter: snapshot name */
@@ -164 +167 @@
             }
 
-            ComPtr<ISnapshot> snapshot;
+            ComPtr<ISnapshot> pSnapshot;
 
             /* assume it's a UUID */
@@ -170 +173 @@
             if (!guid.isEmpty())
             {
-                CHECK_ERROR_BREAK(machine, GetSnapshot(guid, snapshot.asOutParam()));
+                CHECK_ERROR_BREAK(machine, GetSnapshot(guid, pSnapshot.asOutParam()));
             }
             else
             {
                 /* then it must be a name */
-                CHECK_ERROR_BREAK(machine, FindSnapshot(Bstr(a->argv[2]), snapshot.asOutParam()));
-            }
-
-            snapshot->COMGETTER(Id)(guid.asOutParam());
-
-            ComPtr<IProgress> progress;
-            CHECK_ERROR_BREAK(console, DeleteSnapshot(guid, progress.asOutParam()));
-
-            showProgress(progress);
-            LONG iRc;
-            progress->COMGETTER(ResultCode)(&iRc);
-            rc = iRc;
-            if (FAILED(rc))
-            {
-                com::ProgressErrorInfo info(progress);
-                if (info.isBasicAvailable())
-                    RTPrintf("Error: failed to discard snapshot. Error message: %lS\n", info.getText().raw());
-                else
-                    RTPrintf("Error: failed to discard snapshot. No error message available!\n");
-            }
-        }
-        else if (!strcmp(a->argv[1], "discardcurrent"))
-        {
-            if (   (a->argc != 3)
-                || (   strcmp(a->argv[2], "--state")
-                    && strcmp(a->argv[2], "-state")))
-            {
-                errorSyntax(USAGE_SNAPSHOT, "Invalid parameter '%s'", Utf8Str(a->argv[2]).raw());
-                rc = E_FAIL;
-                break;
-            }
-
-            ComPtr<ISnapshot> pCurrentSnapshot;
-            CHECK_ERROR_BREAK(machine, COMGETTER(CurrentSnapshot)(pCurrentSnapshot.asOutParam()));
+                CHECK_ERROR_BREAK(machine, FindSnapshot(Bstr(a->argv[2]), pSnapshot.asOutParam()));
+                pSnapshot->COMGETTER(Id)(guid.asOutParam());
+            }
 
             ComPtr<IProgress> pProgress;
-            CHECK_ERROR_BREAK(console, RestoreSnapshot(pCurrentSnapshot, pProgress.asOutParam()));
+            if (fDelete)
+            {
+                CHECK_ERROR_BREAK(console, DeleteSnapshot(guid, pProgress.asOutParam()));
+            }
+            else
+            {
+                // must be restore
+                CHECK_ERROR_BREAK(console, RestoreSnapshot(pSnapshot, pProgress.asOutParam()));
+            }
 
             showProgress(pProgress);
@@ -221 +201 @@
                 com::ProgressErrorInfo info(pProgress);
                 if (info.isBasicAvailable())
-                    RTPrintf("Error: failed to restore snapshot. Error message: %lS\n", info.getText().raw());
-                else
-                    RTPrintf("Error: failed to restore snapshot. No error message available!\n");
-            }
-
+                    RTPrintf("Error: snapshot operation failed. Error message: %lS\n", info.getText().raw());
+                else
+                    RTPrintf("Error: snapshot operation failed. No error message available!\n");
+            }
         }
         else if (!strcmp(a->argv[1], "edit"))

trunk/src/VBox/Main/MachineImpl.cpp

@@ -7586 +7586 @@
     void handler()
     {
-        machine->discardSnapshotHandler(*this);
+        machine->deleteSnapshotHandler(*this);
     }
 
@@ -9445 +9445 @@
 
 /**
- * Helper struct for SessionMachine::discardSnapshotHandler().
+ * Helper struct for SessionMachine::deleteSnapshotHandler().
  */
 struct MediumDiscardRec
@@ -9484 +9484 @@
  * @note Locks mParent + this + child objects for writing!
  */
-void SessionMachine::discardSnapshotHandler(DeleteSnapshotTask &aTask)
+void SessionMachine::deleteSnapshotHandler(DeleteSnapshotTask &aTask)
 {
     LogFlowThisFuncEnter();
@@ -9895 +9895 @@
                 {
                     mSSData->mStateFilePath = stateFilePath;
+
+                    /* make the snapshot we restored from the current snapshot */
+                    mData->mCurrentSnapshot = aTask.pSnapshot;
                 }
                 else

trunk/src/VBox/Main/include/MachineImpl.h

@@ -1037 +1037 @@
     typedef std::map<ComObjPtr<Machine>, MachineState_T> AffectedMachines;
 
-    void discardSnapshotHandler(DeleteSnapshotTask &aTask);
+    void deleteSnapshotHandler(DeleteSnapshotTask &aTask);
     void restoreSnapshotHandler(RestoreSnapshotTask &aTask);