Changeset 23909 in vbox for trunk/src/VBox/Main

Timestamp:

Oct 20, 2009 3:50:06 PM (16 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

53711

Message:

Main: fix tiny memory leak in GetExtraData

Location:

trunk/src/VBox/Main

Files:

• MachineImpl.cpp (modified) (2 diffs)
• VirtualBoxImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/MachineImpl.cpp

@@ -2743 +2743 @@
 
     /* start with nothing found */
-    Bstr("").cloneTo(aValue);
+    Utf8Str strResult;
 
     AutoReadLock alock (this);
@@ -2749 +2749 @@
     settings::ExtraDataItemsMap::const_iterator it = mData->m_pMachineConfigFile->mapExtraDataItems.find(Utf8Str(aKey));
     if (it != mData->m_pMachineConfigFile->mapExtraDataItems.end())
-    {
         // found:
-        const Utf8Str &strValue = it->second;
-        strValue.cloneTo(aValue);
-    }
+        strResult = it->second;
+
+    /* return the result to caller (may be empty) */
+    strResult.cloneTo(aValue);
 
     return S_OK;

trunk/src/VBox/Main/VirtualBoxImpl.cpp

@@ -1607 +1607 @@
 
     /* start with nothing found */
-    Bstr("").cloneTo(aValue);
+    Utf8Str strResult;
 
     settings::ExtraDataItemsMap::const_iterator it = m->pMainConfigFile->mapExtraDataItems.find(Utf8Str(aKey));
     if (it != m->pMainConfigFile->mapExtraDataItems.end())
-    {
         // found:
-        const Utf8Str &strValue = it->second;
-        strValue.cloneTo(aValue);
-    }
+        strResult = it->second;
+
+    /* return the result to caller (may be empty) */
+    strResult.cloneTo(aValue);
 
     return S_OK;