Changeset 23914 in vbox

Timestamp:

Oct 20, 2009 4:31:36 PM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

53716

Message:

Main/MediumAttachment: very ugly fix for the fact that MediumAttachment instances can't have references to StorageController objects, because the reference would be invalid after changed settings are saved.

Location:

trunk/src/VBox/Main

Files:

• MachineImpl.cpp (modified) (6 diffs)
• MediumAttachmentImpl.cpp (modified) (4 diffs)
• include/MediumAttachmentImpl.h (modified) (4 diffs)

trunk/src/VBox/Main/MachineImpl.cpp

@@ -309 +309 @@
         while (thatIt != thatAtts.end())
         {
-            if ((*it)->controller() == (*thatIt)->controller() &&
-                (*it)->port() == (*thatIt)->port() &&
-                (*it)->device() == (*thatIt)->device() &&
+            if ((*it)->matches((*thatIt)->controllerName(),
+                               (*thatIt)->port(),
+                               (*thatIt)->device()) &&
                 (*it)->passthrough() == (*thatIt)->passthrough() &&
                 (*it)->medium().equalsTo ((*thatIt)->medium()))
@@ -2433 +2433 @@
     ComObjPtr<MediumAttachment> attachment;
     attachment.createObject();
-    rc = attachment->init(this, medium, ctl, aControllerPort, aDevice, aType, indirect);
+    rc = attachment->init(this, medium, aControllerName, aControllerPort, aDevice, aType, indirect);
     CheckComRCReturnRC(rc);
 
@@ -3558 +3558 @@
          ++it)
     {
-        if (Bstr((*it)->controller()->name()) == aName)
+        if (Bstr((*it)->controllerName()) == aName)
             return setError(VBOX_E_OBJECT_IN_USE,
                             tr("Storage controller named '%ls' has still devices attached"),
@@ -5608 +5608 @@
         rc = pAttachment->init(this,
                                medium,
-                               aStorageController,
+                               aStorageController->name(),
                                dev.lPort,
                                dev.lDevice,
@@ -5751 +5751 @@
          ++it)
     {
-        if (Bstr((*it)->controller()->name()) == aName)
+        if (Bstr((*it)->controllerName()) == aName)
             atts.push_back(*it);
     }
@@ -6642 +6642 @@
             rc = attachment->init(this,
                                   diff,
-                                  pAtt->controller(),
+                                  pAtt->controllerName(),
                                   pAtt->port(),
                                   pAtt->device(),

trunk/src/VBox/Main/MediumAttachmentImpl.cpp

@@ -58 +58 @@
 HRESULT MediumAttachment::init(Machine *aParent,
                                Medium *aMedium,
-                               StorageController *aController,
+                               const Bstr &aControllerName,
                                LONG aPort,
                                LONG aDevice,
@@ -65 +65 @@
 {
     LogFlowThisFuncEnter();
-    LogFlowThisFunc(("aParent=%p aMedium=%p aController=%ls aPort=%d aDevice=%d aType=%d aImplicit=%d\n", aParent, aMedium, aController, aPort, aDevice, aType, aImplicit));
+    LogFlowThisFunc(("aParent=%p aMedium=%p aControllerName=%ls aPort=%d aDevice=%d aType=%d aImplicit=%d\n", aParent, aMedium, aControllerName.raw(), aPort, aDevice, aType, aImplicit));
 
     if (aType == DeviceType_HardDisk)
@@ -78 +78 @@
     m.allocate();
     m->medium = aMedium;
-    unconst(m->controller) = aController;
+    unconst(m->controllerName) = aControllerName;
     unconst(m->port)   = aPort;
     unconst(m->device) = aDevice;
@@ -190 +190 @@
 
     /* m->controller is constant during life time, no need to lock */
-    m->controller.queryInterfaceTo(aController);
-
-    LogFlowThisFuncLeave();
-    return S_OK;
+    /** @todo ugly hack, MediumAttachment should have a direct reference
+     * to the storage controller, but can't have that right now due to
+     * how objects are created for settings rollback support. */
+    HRESULT rc = mParent->GetStorageControllerByName(m->controllerName, aController);
+
+    LogFlowThisFuncLeave();
+    return rc;
 }
 

trunk/src/VBox/Main/include/MediumAttachmentImpl.h

@@ -54 +54 @@
     HRESULT init(Machine *aParent,
                  Medium *aMedium,
-                 StorageController *aController,
+                 const Bstr &aControllerName,
                  LONG aPort,
                  LONG aDevice,
@@ -83 +83 @@
 
     const ComObjPtr<Medium> &medium() const { return m->medium; }
-    const ComObjPtr<StorageController> &controller() const { return m->controller; }
+    Bstr controllerName() const { return m->controllerName; }
     LONG port() const { return m->port; }
     LONG device() const { return m->device; }
@@ -89 +89 @@
     bool passthrough() const { AutoReadLock lock(this); return m->passthrough; }
 
-    bool matches(CBSTR aController, LONG aPort, LONG aDevice)
+    bool matches(CBSTR aControllerName, LONG aPort, LONG aDevice)
     {
-        return (    aController == m->controller->name()
+        return (    aControllerName == m->controllerName
                  && aPort == m->port
                  && aDevice == m->device);
@@ -125 +125 @@
 
         ComObjPtr<Medium> medium;
-        ComObjPtr<StorageController> controller;
+        /* Since MediumAttachment is not a first class citizen when it
+         * comes to managing settings, having a reference to the storage
+         * controller will not work - when settings are changed it will point
+         * to the old, uninitialized instance. Changing this requires
+         * substantial changes to MediumImpl.cpp. */
+        Bstr controllerName;
         const LONG port;
         const LONG device;