Changeset 23932 in vbox for trunk/src

Timestamp:

Oct 21, 2009 1:08:35 PM (15 years ago)

Author:

vboxsync

Message:

VBoxManage: fixed bug which caused changing media during runtime to fail

File:

• trunk/src/VBox/Frontends/VBoxManage/VBoxManageStorageController.cpp (modified) (5 diffs)

trunk/src/VBox/Frontends/VBoxManage/VBoxManageStorageController.cpp

@@ -173 +173 @@
     }
 
-    if (fRunTime)
-    {
-        if (   !RTStrICmp(pszMedium, "none")
-            || !RTStrICmp(pszType, "hdd"))
-            errorArgument("DVD/HardDisk Drives can't be changed while the VM is still running\n");
-        if (pszPassThrough)
-            errorArgument("Drive passthrough state can't be changed while the VM is still running\n");
-
+    if (   fRunTime
+        && (   !RTStrICmp(pszMedium, "none")
+            || !RTStrICmp(pszType, "hdd")))
+    {
+        errorArgument("DVD/HardDisk Drives can't be changed while the VM is still running\n");
         goto leave;
     }
+
+    if (fRunTime && pszPassThrough)
+    {
+        errorArgument("Drive passthrough state can't be changed while the VM is still running\n");
+        goto leave;
+    }
+
 
     /* get the mutable session machine */
@@ -214 +218 @@
                 {
                     /* just unmount the floppy/dvd */
-                    CHECK_ERROR (machine, MountMedium(Bstr(pszCtl), port, device, NULL));
+                    CHECK_ERROR (machine, MountMedium(Bstr(pszCtl), port, device, Bstr("")));
+                }
+                else
+                {
+                    errorArgument("No DVD/Floppy Drive attached to the controller '%s'"
+                                  "at the port: %u, device: %u", pszCtl, port, device);
+                    goto leave;
                 }
             }
@@ -239 +249 @@
             /* attach a empty floppy/dvd drive after removing previous attachment */
             machine->DetachDevice(Bstr(pszCtl), port, device);
-            CHECK_ERROR (machine, AttachDevice(Bstr(pszCtl), port, device, deviceType, NULL));
+            CHECK_ERROR (machine, AttachDevice(Bstr(pszCtl), port, device, deviceType, Bstr("")));
         }
     }
@@ -269 +279 @@
                     {
                         machine->DetachDevice(Bstr(pszCtl), port, device);
-                        rc = machine->AttachDevice(Bstr(pszCtl), port, device, DeviceType_DVD, NULL);
+                        rc = machine->AttachDevice(Bstr(pszCtl), port, device, DeviceType_DVD, Bstr(""));
                     }
                 }
                 else
                 {
-                    rc = machine->AttachDevice(Bstr(pszCtl), port, device, DeviceType_DVD, NULL);
+                    rc = machine->AttachDevice(Bstr(pszCtl), port, device, DeviceType_DVD, Bstr(""));
                 }
             }
@@ -393 +403 @@
             if (   !fRunTime
                 && !floppyAttachment)
-                CHECK_ERROR (machine, AttachDevice(Bstr(pszCtl), port, device, DeviceType_Floppy, NULL));
+                CHECK_ERROR (machine, AttachDevice(Bstr(pszCtl), port, device, DeviceType_Floppy, Bstr("")));
 
             /* host drive? */