Changeset 23973 in vbox for trunk/include

Timestamp:

Oct 22, 2009 12:34:22 PM (15 years ago)

Author:

vboxsync

Message:

*,RTFileOpen: Fixing RTFileOpen flag misdesign: The deny, access and action flags are mandatory now.

File:

• trunk/include/iprt/file.h (modified) (5 diffs)

trunk/include/iprt/file.h

@@ -87 +87 @@
                                      /* 0x00000008 is unused atm. */
 
-/** Sharing mode: deny none (the default mode). */
-#define RTFILE_O_DENY_NONE              0x00000000
+/** Sharing mode: deny none. */
+#define RTFILE_O_DENY_NONE              0x00000080
 /** Sharing mode: deny read. */
 #define RTFILE_O_DENY_READ              0x00000010
@@ -103 +103 @@
 #define RTFILE_O_DENY_NOT_DELETE        0x00000040
 /** Sharing mode mask. */
-#define RTFILE_O_DENY_MASK              0x00000070
+#define RTFILE_O_DENY_MASK              0x000000f0
 
 /** Action: Open an existing file (the default action). */
-#define RTFILE_O_OPEN                   0x00000000
+#define RTFILE_O_OPEN                   0x00000700
 /** Action: Create a new file or open an existing one. */
 #define RTFILE_O_OPEN_CREATE            0x00000100
@@ -114 +114 @@
 #define RTFILE_O_CREATE_REPLACE         0x00000300
 /** Action mask. */
-#define RTFILE_O_ACTION_MASK            0x00000300
-
-                                      /*0x00000400
-                                    and 0x00000800 are unused atm. */
+#define RTFILE_O_ACTION_MASK            0x00000700
+
 /** Turns off indexing of files on Windows hosts, *CREATE* only.
  * @remarks Window only. */
@@ -201 +199 @@
  * @remark  This doesn't validate the access mode properly.
  */
-#define RTFILE_O_VALID_MASK             0x1ffFFB77
+#define RTFILE_O_VALID_MASK             0x1ffFFFF7
 
 /** @} */
@@ -224 +222 @@
  * @param   pszFilename     Path to the file which is to be opened. (UTF-8)
  * @param   fOpen           Open flags, i.e a combination of the RTFILE_O_* defines.
- */
-RTR3DECL(int)  RTFileOpen(PRTFILE pFile, const char *pszFilename, unsigned fOpen);
+ *                          The ACCESS, ACTION and DENY flags are mandatory!
+ */
+RTR3DECL(int)  RTFileOpen(PRTFILE pFile, const char *pszFilename, uint32_t fOpen);
 
 /**