Changeset 23973 in vbox for trunk/src/VBox/Devices/Serial

Timestamp:

Oct 22, 2009 12:34:22 PM (16 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

53801

Message:

*,RTFileOpen: Fixing RTFileOpen flag misdesign: The deny, access and action flags are mandatory now.

Location:

trunk/src/VBox/Devices/Serial

Files:

• DrvHostSerial.cpp (modified) (3 diffs)
• DrvRawFile.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/Serial/DrvHostSerial.cpp

@@ -1211 +1211 @@
 /**
  * Construct a char driver instance.
- *  
+ *
  * @copydoc FNPDMDRVCONSTRUCT
  */
@@ -1288 +1288 @@
 #else
 
-    rc = RTFileOpen(&pThis->DeviceFile, pThis->pszDevicePath, RTFILE_O_OPEN | RTFILE_O_READWRITE);
+    rc = RTFileOpen(&pThis->DeviceFile, pThis->pszDevicePath, RTFILE_O_READWRITE | RTFILE_O_OPEN | RTFILE_O_DENY_NONE);
 # ifdef RT_OS_DARWIN
     if (RT_SUCCESS(rc))
-        rc = RTFileOpen(&pThis->DeviceFileR, pThis->pszDevicePath, RTFILE_O_OPEN | RTFILE_O_READ);
+        rc = RTFileOpen(&pThis->DeviceFileR, pThis->pszDevicePath, RTFILE_O_READ | RTFILE_O_OPEN | RTFILE_O_DENY_NONE);
 # endif
 
@@ -1495 +1495 @@
     NULL,
     /* pfnDetach */
-    NULL, 
+    NULL,
     /* pfnPowerOff */
-    NULL, 
+    NULL,
     /* pfnSoftReset */
     NULL,

trunk/src/VBox/Devices/Serial/DrvRawFile.cpp

@@ -150 +150 @@
      * Open the raw file.
      */
-    rc = RTFileOpen(&pThis->OutputFile, pThis->pszLocation, RTFILE_O_CREATE_REPLACE | RTFILE_O_WRITE | RTFILE_O_DENY_NONE);
+    rc = RTFileOpen(&pThis->OutputFile, pThis->pszLocation, RTFILE_O_WRITE | RTFILE_O_CREATE_REPLACE | RTFILE_O_DENY_NONE);
     if (RT_FAILURE(rc))
     {
@@ -180 +180 @@
 
     if (pThis->OutputFile != NIL_RTFILE)
-    {    
+    {
         RTFileClose(pThis->OutputFile);
         pThis->OutputFile = NIL_RTFILE;
@@ -200 +200 @@
 
     if (pThis->OutputFile != NIL_RTFILE)
-    {    
+    {
         RTFileClose(pThis->OutputFile);
         pThis->OutputFile = NIL_RTFILE;