Changeset 23973 in vbox for trunk/src/VBox/VMM

Timestamp:

Oct 22, 2009 12:34:22 PM (16 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

53801

Message:

*,RTFileOpen: Fixing RTFileOpen flag misdesign: The deny, access and action flags are mandatory now.

Location:

trunk/src/VBox/VMM

Files:

• PDMAsyncCompletionFile.cpp (modified) (1 diff)
• testcase/tstPDMAsyncCompletion.cpp (modified) (1 diff)
• testcase/tstPDMAsyncCompletionStress.cpp (modified) (9 diffs)

trunk/src/VBox/VMM/PDMAsyncCompletionFile.cpp

@@ -578 +578 @@
         RTFILE File = NIL_RTFILE;
 
-        rc = RTFileOpen(&File, pszUri, RTFILE_O_OPEN | RTFILE_O_READ | RTFILE_O_DENY_NONE);
+        rc = RTFileOpen(&File, pszUri, RTFILE_O_READ | RTFILE_O_OPEN | RTFILE_O_DENY_NONE);
         if (RT_SUCCESS(rc))
         {

trunk/src/VBox/VMM/testcase/tstPDMAsyncCompletion.cpp

@@ -137 +137 @@
         /* Create the destination as the async completion API can't do this. */
         RTFILE FileTmp;
-        rc = RTFileOpen(&FileTmp, argv[2], RTFILE_O_READWRITE | RTFILE_O_OPEN_CREATE);
+        rc = RTFileOpen(&FileTmp, argv[2], RTFILE_O_READWRITE | RTFILE_O_OPEN_CREATE | RTFILE_O_DENY_NONE);
         if (RT_FAILURE(rc))
         {

trunk/src/VBox/VMM/testcase/tstPDMAsyncCompletionStress.cpp

@@ -145 +145 @@
     volatile uint32_t          cTasksActiveCurr;
     /** Pointer to the array of task. */
-    PPDMACTESTFILETASK         paTasks; 
+    PPDMACTESTFILETASK         paTasks;
     /** I/O thread handle. */
     PPDMTHREAD                 hThread;
@@ -167 +167 @@
     while (cbLeft)
     {
-        size_t cbCompare; 
+        size_t cbCompare;
         unsigned iSeg = off / pTestFile->cbFileSegment;
         PPDMACTESTFILESEG pSeg = &pTestFile->paSegs[iSeg];
@@ -195 +195 @@
     while (cbLeft)
     {
-        size_t cbFill; 
+        size_t cbFill;
         unsigned iSeg = off / pTestFile->cbFileSegment;
         PPDMACTESTFILESEG pSeg = &pTestFile->paSegs[iSeg];
@@ -251 +251 @@
     /* Set new file size of required */
     if ((uint64_t)pTestTask->off + pTestTask->DataSeg.cbSeg > pTestFile->cbFileCurr)
-        pTestFile->cbFileCurr = pTestTask->off + pTestTask->DataSeg.cbSeg; 
+        pTestFile->cbFileCurr = pTestTask->off + pTestTask->DataSeg.cbSeg;
 
     AssertMsg(pTestFile->cbFileCurr <= pTestFile->cbFileMax,
@@ -286 +286 @@
 
     AssertMsg(pTestFile->cbFileCurr >= pTestTask->DataSeg.cbSeg, ("Impossible\n"));
-    pTestTask->off = RTRandU64Ex(0, pTestFile->cbFileCurr - pTestTask->DataSeg.cbSeg); 
+    pTestTask->off = RTRandU64Ex(0, pTestFile->cbFileCurr - pTestTask->DataSeg.cbSeg);
 
     /* Allocate data buffer. */
@@ -329 +329 @@
     {
         unsigned iTaskCurr = 0;
-        
+
 
         /* Fill all tasks */
@@ -411 +411 @@
     pTestFile->cbFileMax     = RTRandU64Ex(FILE_SIZE_MIN, FILE_SIZE_MAX) & ~(511UL);
     pTestFile->cbFileCurr    = 0;
-    pTestFile->cbFileSegment = RTRandU32Ex(SEGMENT_SIZE_MIN, RT_MIN(pTestFile->cbFileMax, SEGMENT_SIZE_MAX)) & ~((size_t)511); 
+    pTestFile->cbFileSegment = RTRandU32Ex(SEGMENT_SIZE_MIN, RT_MIN(pTestFile->cbFileMax, SEGMENT_SIZE_MAX)) & ~((size_t)511);
 
     Assert(pTestFile->cbFileMax >= pTestFile->cbFileSegment);
@@ -454 +454 @@
 
                 RTFILE FileTmp;
-                rc = RTFileOpen(&FileTmp, szFile, RTFILE_O_CREATE | RTFILE_O_READWRITE);
+                rc = RTFileOpen(&FileTmp, szFile, RTFILE_O_READWRITE | RTFILE_O_CREATE | RTFILE_O_DENY_NONE);
                 if (RT_SUCCESS(rc))
                 {
@@ -504 +504 @@
 }
 
-/** 
+/**
  * Closes a test file.
  *