Changeset 23975 in vbox

Timestamp:

Oct 22, 2009 12:54:52 PM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

53806

Message:

AsyncCompletion: Fix possible data corruption

Location:

trunk/src/VBox/VMM

Files:

• PDMAsyncCompletionFileCache.cpp (modified) (11 diffs)
• PDMAsyncCompletionFileInternal.h (modified) (1 diff)

trunk/src/VBox/VMM/PDMAsyncCompletionFileCache.cpp

@@ -490 +490 @@
     pEntry->fFlags &= ~PDMACFILECACHE_ENTRY_IO_IN_PROGRESS;
 
+    /* Process waiting segment list. The data in entry might have changed inbetween. */
+    PPDMACFILETASKSEG pCurr = pEntry->pWaitingHead;
+
+    AssertMsg((pCurr && pEntry->pWaitingTail) || (!pCurr && !pEntry->pWaitingTail),
+                ("The list tail was not updated correctly\n"));
+    pEntry->pWaitingTail = NULL;
+    pEntry->pWaitingHead = NULL;
+
     if (pTask->enmTransferType == PDMACTASKFILETRANSFER_WRITE)
     {
         pEntry->fFlags &= ~PDMACFILECACHE_ENTRY_IS_DIRTY;
-
-        /* Process waiting segment list. The data in entry might have changed inbetween. */
-        PPDMACFILETASKSEG pCurr = pEntry->pHead;
 
         while (pCurr)
@@ -520 +525 @@
         AssertMsg(pTask->enmTransferType == PDMACTASKFILETRANSFER_READ, ("Invalid transfer type\n"));
         AssertMsg(!(pEntry->fFlags & PDMACFILECACHE_ENTRY_IS_DIRTY),("Invalid flags set\n"));
-
-        /* Process waiting segment list. */
-        PPDMACFILETASKSEG pCurr = pEntry->pHead;
 
         while (pCurr)
@@ -546 +548 @@
         }
     }
-
-    pEntry->pHead = NULL;
 
     if (pEntry->fFlags & PDMACFILECACHE_ENTRY_IS_DIRTY)
@@ -844 +844 @@
     pEntryNew->pList        = NULL;
     pEntryNew->cbData       = cbData;
-    pEntryNew->pHead        = NULL;
+    pEntryNew->pWaitingHead = NULL;
+    pEntryNew->pWaitingTail = NULL;
     pEntryNew->pbData       = (uint8_t *)RTMemPageAlloc(cbData);
 
@@ -854 +855 @@
 
     return pEntryNew;
+}
+
+/**
+ * Adds a segment to the waiting list for a cache entry
+ * which is currently in progress.
+ *
+ * @returns nothing.
+ * @param   pEntry    The cache entry to add the segment to.
+ * @param   pSeg      The segment to add.
+ */
+static void pdmacFileEpCacheEntryAddWaitingSegment(PPDMACFILECACHEENTRY pEntry, PPDMACFILETASKSEG pSeg)
+{
+    pSeg->pNext = NULL;
+
+    if (pEntry->pWaitingHead)
+    {
+        AssertPtr(pEntry->pWaitingTail);
+
+        pEntry->pWaitingTail->pNext = pSeg;
+        pEntry->pWaitingTail = pSeg;
+    }
+    else
+    {
+        Assert(!pEntry->pWaitingTail);
+
+        pEntry->pWaitingHead = pSeg;
+        pEntry->pWaitingTail = pSeg;
+    }
 }
 
@@ -971 +1000 @@
                             ADVANCE_SEGMENT_BUFFER(pSeg->cbTransfer);
 
-                            pSeg->pNext = pEntry->pHead;
-                            pEntry->pHead = pSeg;
+                            pdmacFileEpCacheEntryAddWaitingSegment(pEntry, pSeg);
 
                             off      += pSeg->cbTransfer;
@@ -1051 +1079 @@
                     ADVANCE_SEGMENT_BUFFER(pSeg->cbTransfer);
 
-                    pSeg->pNext = pEntry->pHead;
-                    pEntry->pHead = pSeg;
+                    pdmacFileEpCacheEntryAddWaitingSegment(pEntry, pSeg);
 
                     off      += pSeg->cbTransfer;
@@ -1136 +1163 @@
                     ADVANCE_SEGMENT_BUFFER(pSeg->cbTransfer);
 
-                    pSeg->pNext = pEntryNew->pHead;
-                    pEntryNew->pHead = pSeg;
+                    pdmacFileEpCacheEntryAddWaitingSegment(pEntryNew, pSeg);
 
                     off        += pSeg->cbTransfer;
@@ -1274 +1300 @@
                             ADVANCE_SEGMENT_BUFFER(pSeg->cbTransfer);
 
-                            pSeg->pNext = pEntry->pHead;
-                            pEntry->pHead = pSeg;
+                            pdmacFileEpCacheEntryAddWaitingSegment(pEntry, pSeg);
 
                             off       += pSeg->cbTransfer;
@@ -1335 +1360 @@
                                 ADVANCE_SEGMENT_BUFFER(pSeg->cbTransfer);
 
-                                pSeg->pNext = pEntry->pHead;
-                                pEntry->pHead = pSeg;
+                                pdmacFileEpCacheEntryAddWaitingSegment(pEntry, pSeg);
 
                                 off       += pSeg->cbTransfer;
@@ -1424 +1448 @@
                     ADVANCE_SEGMENT_BUFFER(pSeg->cbTransfer);
 
-                    pSeg->pNext = pEntry->pHead;
-                    pEntry->pHead = pSeg;
+                    pdmacFileEpCacheEntryAddWaitingSegment(pEntry, pSeg);
 
                     off       += pSeg->cbTransfer;

trunk/src/VBox/VMM/PDMAsyncCompletionFileInternal.h

@@ -229 +229 @@
     /** Pointer to the memory containing the data. */
     uint8_t                        *pbData;
-    /** List of tasks waiting for this one to finish. */
-    PPDMACFILETASKSEG               pHead;
+    /** Head of list of tasks waiting for this one to finish. */
+    PPDMACFILETASKSEG               pWaitingHead;
+    /** Tail of list of tasks waiting for this one to finish. */
+    PPDMACFILETASKSEG               pWaitingTail;
 } PDMACFILECACHEENTRY, *PPDMACFILECACHEENTRY;
 /** I/O is still in progress for this entry. This entry is not evictable. */