Changeset 24021 in vbox

Timestamp:

Oct 23, 2009 11:29:18 AM (16 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

53864

Message:

Use KeSetSystemAffinityThread in RTThreadPreemptDisable/Enable.
Removed IPI hacks as queuing a DPC when the target CPU is not running at DISPATCH_LEVEL immediately interrupts it.

Location:

trunk/src/VBox/Runtime/r0drv/nt

Files:

• initterm-r0drv-nt.cpp (modified) (4 diffs)
• internal-r0drv-nt.h (modified) (2 diffs)
• mp-r0drv-nt.cpp (modified) (3 diffs)
• thread-r0drv-nt.cpp (modified) (2 diffs)

trunk/src/VBox/Runtime/r0drv/nt/initterm-r0drv-nt.cpp ¶

@@ -54 +54 @@
 
 /** ExSetTimerResolution, introduced in W2K. */
-PFNMYEXSETTIMERRESOLUTION   g_pfnrtNtExSetTimerResolution;
+PFNMYEXSETTIMERRESOLUTION       g_pfnrtNtExSetTimerResolution;
 /** KeFlushQueuedDpcs, introduced in XP. */
-PFNMYKEFLUSHQUEUEDDPCS      g_pfnrtNtKeFlushQueuedDpcs;
-/** HalRequestIpi, introduced in ??. */
-PFNHALREQUESTIPI            g_pfnrtNtHalRequestIpi;
-/** HalSendSoftwareInterrupt */
-PFNHALSENDSOFTWAREINTERRUPT g_pfnrtNtHalSendSoftwareInterrupt;
-/** SendIpi handler based on Windows version */
-PFNRTSENDIPI                g_pfnrtSendIpi;
-/** KeIpiGenericCall - Windows Server 2003+ only */
-PFNRTKEIPIGENERICCALL       g_pfnrtKeIpiGenericCall;
+PFNMYKEFLUSHQUEUEDDPCS          g_pfnrtNtKeFlushQueuedDpcs;
+/** KeSetSystemAffinityThread - Windows 2000+ */
+PFNRTKESETSYSTEMAFFINITYTHREAD  g_pfnrtKeSetSystemAffinityThread;
+
 
 /** Offset of the _KPRCB::QuantumEnd field. 0 if not found. */
@@ -91 +86 @@
     g_pfnrtNtExSetTimerResolution = NULL;
     g_pfnrtNtKeFlushQueuedDpcs = NULL;
-    g_pfnrtNtHalRequestIpi = NULL;
-    g_pfnrtNtHalSendSoftwareInterrupt = NULL;
-    g_pfnrtKeIpiGenericCall = NULL;
+        g_pfnrtKeSetSystemAffinityThread = NULL;
 #else
     /*
@@ -105 +98 @@
     g_pfnrtNtKeFlushQueuedDpcs = (PFNMYKEFLUSHQUEUEDDPCS)MmGetSystemRoutineAddress(&RoutineName);
 
-    RtlInitUnicodeString(&RoutineName, L"HalRequestIpi");
-    g_pfnrtNtHalRequestIpi = (PFNHALREQUESTIPI)MmGetSystemRoutineAddress(&RoutineName);
-
-    RtlInitUnicodeString(&RoutineName, L"HalSendSoftwareInterrupt");
-    g_pfnrtNtHalSendSoftwareInterrupt = (PFNHALSENDSOFTWAREINTERRUPT)MmGetSystemRoutineAddress(&RoutineName);
-
-    RtlInitUnicodeString(&RoutineName, L"KeIpiGenericCall");
-    g_pfnrtKeIpiGenericCall = (PFNRTKEIPIGENERICCALL)MmGetSystemRoutineAddress(&RoutineName);
+    RtlInitUnicodeString(&RoutineName, L"KeSetSystemAffinityThread");
+    g_pfnrtKeSetSystemAffinityThread = (PFNRTKESETSYSTEMAFFINITYTHREAD)MmGetSystemRoutineAddress(&RoutineName);
 #endif
 
@@ -123 +110 @@
     BOOLEAN fChecked = PsGetVersion(&MajorVersion, &MinorVersion, &BuildNumber, NULL);
 
-    g_pfnrtSendIpi = rtMpSendIpiDummy;
-#ifndef IPRT_TARGET_NT4
-    if (    g_pfnrtNtHalRequestIpi
-        &&  MajorVersion == 6
-        &&  MinorVersion == 0)
-    {
-        /* Vista or Windows Server 2008 */
-        g_pfnrtSendIpi = rtMpSendIpiVista;
-    }
-    else
-    if (    g_pfnrtNtHalSendSoftwareInterrupt
-        &&  MajorVersion == 6
-        &&  MinorVersion == 1)
-    {
-        /* Windows 7 or Windows Server 2008 R2 */
-        g_pfnrtSendIpi = rtMpSendIpiWin7;
-    }
-    /* Windows XP should send always send an IPI -> VERIFY */
-#endif
     KIRQL OldIrql;
     KeRaiseIrql(DISPATCH_LEVEL, &OldIrql); /* make sure we stay on the same cpu */

trunk/src/VBox/Runtime/r0drv/nt/internal-r0drv-nt.h ¶

@@ -41 +41 @@
 typedef ULONG (__stdcall *PFNMYEXSETTIMERRESOLUTION)(ULONG, BOOLEAN);
 typedef VOID (__stdcall *PFNMYKEFLUSHQUEUEDDPCS)(VOID);
-typedef VOID (__stdcall *PFNHALREQUESTIPI)(KAFFINITY TargetSet);
-typedef VOID (__stdcall *PFNHALSENDSOFTWAREINTERRUPT)(ULONG ProcessorNumber, KIRQL Irql);
-typedef int (__stdcall *PFNRTSENDIPI)(RTCPUID idCpu);
-typedef ULONG_PTR (__stdcall *PFNRTKEIPIGENERICCALL)(PKIPI_BROADCAST_WORKER BroadcastFunction, ULONG_PTR  Context);
+typedef VOID (__stdcall *PFNRTKESETSYSTEMAFFINITYTHREAD)(KAFFINITY);
 
 /*******************************************************************************
@@ -52 +49 @@
 extern PFNMYEXSETTIMERRESOLUTION    g_pfnrtNtExSetTimerResolution;
 extern PFNMYKEFLUSHQUEUEDDPCS       g_pfnrtNtKeFlushQueuedDpcs;
-extern PFNHALREQUESTIPI             g_pfnrtNtHalRequestIpi;
-extern PFNHALSENDSOFTWAREINTERRUPT  g_pfnrtNtHalSendSoftwareInterrupt;
-extern PFNRTSENDIPI                 g_pfnrtSendIpi;
-extern PFNRTKEIPIGENERICCALL        g_pfnrtKeIpiGenericCall;
+extern PFNRTKESETSYSTEMAFFINITYTHREAD g_pfnrtKeSetSystemAffinityThread;
 extern uint32_t                     g_offrtNtPbQuantumEnd;
 extern uint32_t                     g_cbrtNtPbQuantumEnd;
 extern uint32_t                     g_offrtNtPbDpcQueueDepth;
-
-
-int rtMpSendIpiVista(RTCPUID idCpu);
-int rtMpSendIpiWin7(RTCPUID idCpu);
-int rtMpSendIpiDummy(RTCPUID idCpu);
 
 RT_C_DECLS_END

trunk/src/VBox/Runtime/r0drv/nt/mp-r0drv-nt.cpp ¶

@@ -347 +347 @@
 }
 
-#ifndef IPRT_TARGET_NT4
-
-ULONG_PTR rtMpIpiGenericCall(ULONG_PTR  Argument)
-{
-    return 0;
-}
-
-int rtMpSendIpiVista(RTCPUID idCpu)
-{
-    g_pfnrtKeIpiGenericCall(rtMpIpiGenericCall, 0);
-////    g_pfnrtNtHalRequestIpi(1 << idCpu);
-    return VINF_SUCCESS;
-}
-
-int rtMpSendIpiWin7(RTCPUID idCpu)
-{
-    g_pfnrtKeIpiGenericCall(rtMpIpiGenericCall, 0);
-////    g_pfnrtNtHalSendSoftwareInterrupt(idCpu, DISPATCH_LEVEL);
-    return VINF_SUCCESS;
-}
-#endif /* IPRT_TARGET_NT4 */
-
-int rtMpSendIpiDummy(RTCPUID idCpu)
-{
-    return VERR_NOT_IMPLEMENTED;
-}
-
 RTDECL(int) RTMpPokeCpu(RTCPUID idCpu)
 {
@@ -380 +353 @@
               ? VERR_CPU_NOT_FOUND
               : VERR_CPU_OFFLINE;
-
-    int rc = g_pfnrtSendIpi(idCpu);
-    if (rc == VINF_SUCCESS)
-        return rc;
 
     /* Fallback. */
@@ -407 +376 @@
 
     /* Assuming here that high importance DPCs will be delivered immediately; or at least an IPI will be sent immediately.
-     * @note: not true on at least Vista & Windows 7
+     * @note: seems to be true on Vista
      */
     BOOLEAN bRet = KeInsertQueueDpc(&aPokeDpcs[idCpu], 0, 0);

trunk/src/VBox/Runtime/r0drv/nt/thread-r0drv-nt.cpp ¶

@@ -170 +170 @@
     Assert(KeGetCurrentIrql() <= DISPATCH_LEVEL);
 
+#ifndef IPRT_TARGET_NT4
+    Assert(g_pfnrtKeSetSystemAffinityThread);
+    g_pfnrtKeSetSystemAffinityThread((KAFFINITY)1 << KeGetCurrentProcessorNumber());
+#else
     KeRaiseIrql(DISPATCH_LEVEL, &pState->uchOldIrql);
+#endif
     RT_ASSERT_PREEMPT_CPUID_DISABLE(pState);
 }
@@ -180 +185 @@
 
     RT_ASSERT_PREEMPT_CPUID_RESTORE(pState);
+#ifndef IPRT_TARGET_NT4
+    Assert(g_pfnrtKeSetSystemAffinityThread);
+    g_pfnrtKeSetSystemAffinityThread(KeQueryActiveProcessors());
+#else
     KeLowerIrql(pState->uchOldIrql);
+#endif
     pState->uchOldIrql = 255;
 }