Changeset 24023 in vbox for trunk/src/VBox

Timestamp:

Oct 23, 2009 11:40:50 AM (15 years ago)

Author:

vboxsync

Message:

VbglR3: Some cleanup.

File:

• trunk/src/VBox/Additions/common/VBoxGuestLib/VBoxGuestR3LibHostVersion.cpp (modified) (5 diffs)

trunk/src/VBox/Additions/common/VBoxGuestLib/VBoxGuestR3LibHostVersion.cpp

@@ -70 +70 @@
  *
  * @param   u32ClientId          The client id returned by VbglR3InfoSvcConnect().
- * @param   bUpdate              Receives pointer to boolean flag indicating whether 
+ * @param   bUpdate              Receives pointer to boolean flag indicating whether
                                  an update was found or not.
  * @param   ppszHostVersion      Receives pointer of allocated version string.
@@ -86 +86 @@
     Assert(ppszGuestVersion);
 
-    /* We assume we have an update initially. 
+    /* We assume we have an update initially.
        Every block down below is allowed to veto */
     *bUpdate = true;
@@ -110 +110 @@
         }
         VbglR3GuestPropReadValueFree(pszCheckHostVersion);
-    }    
-
+    }
+
+    /* Collect all needed information */
     /* Make sure we only notify the user once by comparing the host version with
      * the last checked host version (if any) */
@@ -143 +144 @@
         }
 
+        /* Look up guest version */
         if (RT_SUCCESS(rc))
         {
-            /* Look up guest version */
             rc = VbglR3GetAdditionsVersion(ppszGuestVersion, NULL /* Revision not needed here */);
-        }
-    }
-     
+            if (RT_FAILURE(rc))
+                LogFlow(("Could not read VBox guest version! rc = %d\n", rc));
+        }
+    }
+
     /* Do the actual version comparison (if needed, see block(s) above) */
     if (RT_SUCCESS(rc) && *bUpdate)
@@ -202 +205 @@
 {
     Assert(u32ClientId > 0);
-    Assert(pszVer);  
+    Assert(pszVer);
     return VbglR3GuestPropWriteValue(u32ClientId, "/VirtualBox/GuestAdd/HostVerLastChecked", pszVer);
 }