Changeset 2404 in vbox for trunk/src/libs/xpcom18a4/ipc/ipcd

Timestamp:

Apr 27, 2007 3:40:20 PM (18 years ago)

Author:

vboxsync

Message:

XPCOM/IPC: Disable inheritance of the IPC socket's file descriptor to let the IPC daemon see the client termination even if one client's children (or their children) is still running.

Location:

trunk/src/libs/xpcom18a4/ipc/ipcd

Files:

• client/src/ipcConnectionUnix.cpp (modified) (1 diff)
• daemon/src/ipcdUnix.cpp (modified) (1 diff)

trunk/src/libs/xpcom18a4/ipc/ipcd/client/src/ipcConnectionUnix.cpp

@@ -179 +179 @@
   }
 
+  // disable inheritance of the IPC socket by children started
+  // using non-NSPR process API
+  PRStatus status = PR_SetFDInheritable(fd, PR_FALSE);
+  if (status != PR_SUCCESS)
+  {
+    LOG(("coudn't make IPC socket non-inheritable [err=%d]\n", PR_GetError()));
+    return NULL;
+  }
+
   // store this only if we are going to succeed.
   s->fds[SOCK].fd = fd;

trunk/src/libs/xpcom18a4/ipc/ipcd/daemon/src/ipcdUnix.cpp

@@ -508 +508 @@
             kill(getppid(), SIGINT);
         }
-#endif
-    }
+    }
+#endif
 
     return 0;