Changeset 24207 in vbox for trunk/src/VBox/VMM/VMMR0

Timestamp:

Oct 30, 2009 4:21:35 PM (16 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

54154

Message:

Check if we need to intercept invlpg; we catch all page table updates, so there's no need unless there are dirty (unmonitored) pages.
The InvalidatePage handler should only check for dirty pages for the same reason. Restricted to R0 for now.

Again a risky change.

Location:

trunk/src/VBox/VMM/VMMR0

Files:

• HWSVMR0.cpp (modified) (1 diff)
• HWVMXR0.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMR0/HWSVMR0.cpp

@@ -942 +942 @@
 #endif
 
+    /* Check if we need to intercept invlpg; we catch all page table updates, so there's no need unless there are dirty (unmonitored) pages. */
+    if (PGMHasDirtyPages(pVM))
+        pVMCB->ctrl.u32InterceptCtrl1 |= SVM_CTRL1_INTERCEPT_INVLPG;
+    else
+        pVMCB->ctrl.u32InterceptCtrl1 &= ~SVM_CTRL1_INTERCEPT_INVLPG;
+
     /* Done. */
     pVCpu->hwaccm.s.fContextUseFlags &= ~HWACCM_CHANGED_ALL_GUEST;

trunk/src/VBox/VMM/VMMR0/HWVMXR0.cpp

@@ -1863 +1863 @@
 
     vmxR0UpdateExceptionBitmap(pVM, pVCpu, pCtx);
+
+    /* Check if we need to intercept invlpg; we catch all page table updates, so there's no need unless there are dirty (unmonitored) pages. */
+    val = pVCpu->hwaccm.s.vmx.proc_ctls;
+    if (PGMHasDirtyPages(pVM))
+        pVCpu->hwaccm.s.vmx.proc_ctls |= VMX_VMCS_CTRL_PROC_EXEC_CONTROLS_INVLPG_EXIT;
+    else
+        pVCpu->hwaccm.s.vmx.proc_ctls &= ~VMX_VMCS_CTRL_PROC_EXEC_CONTROLS_INVLPG_EXIT;
+
+    if (val != pVCpu->hwaccm.s.vmx.proc_ctls)
+    {
+        rc = VMXWriteVMCS(VMX_VMCS_CTRL_PROC_EXEC_CONTROLS, pVCpu->hwaccm.s.vmx.proc_ctls);
+        AssertRC(rc);
+    }
 
 #ifdef VBOX_WITH_AUTO_MSR_LOAD_RESTORE