Changeset 24344 in vbox

Timestamp:

Nov 4, 2009 4:34:16 PM (15 years ago)

Author:

vboxsync

Message:

Main: fix a really nasty problem in the Machine destructor which never detached non-harddisk media when the machine object was deleted. The problem exhibited itself that when a machine was inaccessible for some reason (e.g. hard disk inaccessible) and also had non-hard disk media attached, debug code would assert somewhere very deep in media backreferences because first the machine was loaded, then marked inaccessible and destroyed (except for the non-harddisk media which never got detached), and then Machine::GetAccessible would retry loading that machine and couldn't attach anything because the old dead attachment was still in the backreferences

File:

• trunk/src/VBox/Main/MachineImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/MachineImpl.cpp

@@ -5176 +5176 @@
         {
             ComObjPtr<Medium> hd = (*it)->medium();
-            if (hd.isNull() || (*it)->type() != DeviceType_HardDisk)
+            if (hd.isNull())
                 continue;
             HRESULT rc = hd->detachFrom(mData->mUuid, snapshotId());