Changeset 24442 in vbox for trunk/src

Timestamp:

Nov 6, 2009 1:49:49 PM (15 years ago)

Author:

vboxsync

Message:

AsyncCompletion: New key to enable the host cache with async I/O. Not supported on Linux

Location:

trunk/src/VBox/VMM

Files:

• PDMAsyncCompletionFile.cpp (modified) (2 diffs)
• PDMAsyncCompletionFileInternal.h (modified) (1 diff)

trunk/src/VBox/VMM/PDMAsyncCompletionFile.cpp

@@ -533 +533 @@
     if (RT_SUCCESS(rc))
     {
+        /* Check if the host cache should be used too. */
+#ifndef RT_OS_LINUX
+        rc = CFGMR3QueryBoolDef(pCfgNode, "HostCacheEnabled", &pEpClassFile->fHostCacheEnabled, false);
+        AssertLogRelRCReturn(rc, rc);
+#else
+        /*
+         * Host cache + async I/O is not supported on Linux. Check if the user enabled the cache,
+         * leave a warning and disable it always.
+         */
+        bool fDummy;
+        rc = CFGMR3QueryBoolDef(pCfgNode, "HostCacheEnabled", &fDummy);
+        if (RT_SUCCESS(rc))
+            LogRel(("AIOMgr: The host cache is not supported with async I/O on Linux\n"));
+
+        pEpClassFile->fHostCacheEnabled = false;
+#endif
+
         /* Check if the cache was disabled by the user. */
         rc = CFGMR3QueryBoolDef(pCfgNode, "CacheEnabled", &pEpClassFile->fCacheEnabled, true);
@@ -611 +628 @@
             {
                 fFileFlags &= ~RTFILE_O_WRITE_THROUGH;
+
+#if defined(RT_OS_LINUX)
+                AssertMsg(!pEpClassFile->fHostCacheEnabled, ("Host cache + async I/O is not supported on Linux\n"));
                 fFileFlags |= RTFILE_O_NO_CACHE;
+#else
+                if (!pEpClassFile->fHostCacheEnabled)
+                    fFileFlags |= RTFILE_O_NO_CACHE;
+#endif
             }
 

trunk/src/VBox/VMM/PDMAsyncCompletionFileInternal.h

@@ -334 +334 @@
     /** Flag whether the file data cache is enabled. */
     bool                                fCacheEnabled;
+    /** Flag whether the host cache should be used too. */
+    bool                                fHostCacheEnabled;
     /** Critical section protecting the list of async I/O managers. */
     RTCRITSECT                          CritSect;