Changeset 24529 in vbox

Timestamp:

Nov 9, 2009 11:16:22 PM (15 years ago)

Author:

vboxsync

Message:

AsyncCompletion: Fix reference leak of cached entries. Blocked further cache operations

File:

• trunk/src/VBox/VMM/PDMAsyncCompletionFileCache.cpp (modified) (10 diffs)

trunk/src/VBox/VMM/PDMAsyncCompletionFileCache.cpp

@@ -700 +700 @@
                    "/PDM/AsyncCompletion/File/CacheBuffersReused",
                    STAMUNIT_COUNT, "Number of times a buffer could be reused");
+    STAMR3Register(pClassFile->Core.pVM, &pCache->uAdaptVal,
+                   STAMTYPE_U32, STAMVISIBILITY_ALWAYS,
+                   "/PDM/AsyncCompletion/File/CacheAdaptValue",
+                   STAMUNIT_COUNT,
+                   "Adaption value of the cache");
 #endif
 
@@ -1218 +1223 @@
             else
             {
+                 if (pEntryBestFit)
+                    pdmacFileEpCacheEntryRelease(pEntryBestFit);
+
                 /*
                  * Align the size to a 4KB boundary.
@@ -1412 +1420 @@
                     RTSemRWReleaseWrite(pEndpointCache->SemRWEntries);
                 }
-                else
+                else /* Deprecated flag not set */
                 {
                     /* If the entry is dirty it must be also in progress now and we have to defer updating it again. */
@@ -1452 +1460 @@
                             STAM_COUNTER_INC(&pEndpointCache->StatWriteDeferred);
                         }
-                        else
+                        else /* Deprecate buffer */
                         {
                             LogFlow(("Deprecating buffer for entry %#p\n", pEntry));
@@ -1492 +1500 @@
                         RTSemRWReleaseWrite(pEndpointCache->SemRWEntries);
                     }
-                    else
+                    else /* Dirty bit not set */
                     {
                         /*
@@ -1523 +1531 @@
                             RTSemRWReleaseWrite(pEndpointCache->SemRWEntries);
                         }
-                        else
+                        else /* I/O in progres flag not set */
                         {
                             /* Write as much as we can into the entry and update the file. */
@@ -1543 +1551 @@
                             pdmacFileCacheWriteToEndpoint(pEntry);
                         }
-                    }
+                    } /* Dirty bit not set */
 
                     /* Move this entry to the top position */
@@ -1549 +1557 @@
                     pdmacFileCacheEntryAddToList(&pCache->LruFrequentlyUsed, pEntry);
                     RTCritSectLeave(&pCache->CritSect);
-                }
+                } /* Deprecated flag not set. */
             }
-            else
+            else /* Entry is on the ghost list */
             {
                 uint8_t *pbBuffer = NULL;
@@ -1599 +1607 @@
             pdmacFileEpCacheEntryRelease(pEntry);
         }
-        else
+        else /* No entry found */
         {
             /*
@@ -1620 +1628 @@
             }
             else
+            {
+                if (pEntryBestFit)
+                    pdmacFileEpCacheEntryRelease(pEntryBestFit);
+
                 cbToWrite = cbWrite;
+            }
 
             cbWrite -= cbToWrite;