Changeset 2454 in kBuild

Timestamp:

Jul 7, 2011 7:51:25 PM (13 years ago)

Author:

bird

Message:

kmk: Applied r1.13 to w32/pathstuff.c, fixing crash if PATH ends with a quote. Fixes #93.

File:

• trunk/src/kmk/w32/pathstuff.c (modified) (3 diffs)

trunk/src/kmk/w32/pathstuff.c

@@ -1 +1 @@
 /* Path conversion for Windows pathnames.
 Copyright (C) 1996, 1997, 1998, 1999, 2000, 2001, 2002, 2003, 2004, 2005, 2006,
-2007 Free Software Foundation, Inc.
+2007, 2009 Free Software Foundation, Inc.
 This file is part of GNU Make.
 
@@ -52 +52 @@
 
     /* is this a multi-element Path ? */
+    /* FIXME: Perhaps use ":;\"" in strpbrk to convert all quotes to
+       delimiters as well, as a way to handle quoted directories in
+       PATH?  */
     for (p = Path, etok = strpbrk(p, ":;");
          etok;
@@ -77 +80 @@
                 ;
             etok = strpbrk(p, ":;");        /* find next delimiter */
-            *etok = to_delim;
-            p = ++etok;
+            if (etok) {
+                *etok = to_delim;
+                p = ++etok;
+            } else
+                p += strlen(p);
         } else {
             /* found another one, no drive letter */