Changeset 24567 in vbox for trunk/src/VBox

Timestamp:

Nov 10, 2009 8:05:55 PM (15 years ago)

Author:

vboxsync

Message:

VM.cpp: Always write VMSetError messages to the release log. Main may delay logging them and confuse things.

File:

• trunk/src/VBox/VMM/VM.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/VM.cpp

@@ -3578 +3578 @@
 DECLCALLBACK(void) vmR3SetErrorUV(PUVM pUVM, int rc, RT_SRC_POS_DECL, const char *pszFormat, va_list *pArgs)
 {
+    /*
+     * Log the error.
+     */
+    va_list va3;
+    va_copy(va3, *pArgs);
+    RTLogRelPrintf("VMSetError: %s(%d) %s\nVMSetError: %N\n", pszFile, iLine, pszFunction, pszFormat, &va3);
+    va_end(va3);
+
 #ifdef LOG_ENABLED
-    /*
-     * Log the error.
-     */
-    va_list va3;
     va_copy(va3, *pArgs);
     RTLogPrintf("VMSetError: %s(%d) %s\n%N\n", pszFile, iLine, pszFunction, pszFormat, &va3);
@@ -3609 +3613 @@
     }
     RTCritSectLeave(&pUVM->vm.s.AtErrorCritSect);
-
-    /*
-     * Write the error to the release log if there weren't anyone to callback.
-     */
-    if (!fCalledSomeone)
-    {
-        va_list va3;
-        va_copy(va3, *pArgs);
-        RTLogRelPrintf("VMSetError: %s(%d) %s\nVMSetError: %N\n", pszFile, iLine, pszFunction, pszFormat, &va3);
-        va_end(va3);
-    }
 }