VBox

Timestamp:

Nov 11, 2009 3:24:39 PM (15 years ago)

Author:

vboxsync

Message:

Main: fixed an uninitialized variable found by valgrind introduced with r50960.

File:

trunk/src/VBox/Main/linux/NetIf-linux.cpp

-              r23203
+              r24592
 static int getInterfaceInfo(int iSocket, const char *pszName, PNETIFINFO pInfo)
+{
+    // Zeroing out pInfo is a bad idea as it should contain both short and long names at this point.
+    //memset(pInfo, 0, sizeof(*pInfo));
+    // Zeroing out pInfo is a bad idea as it should contain both short and long names at
+    // this point. So make sure the strucure is cleared by the caller if necessary!
+    // memset(pInfo, 0, sizeof(*pInfo));
     struct ifreq Req;
     memset(&Req, 0, sizeof(Req));
 …
                 char *pszName = buf+iFirstNonWS;
                 NETIFINFO Info;
+                RT_ZERO(Info);
                 rc = getInterfaceInfo(sock, pszName, &Info);
                 if (RT_FAILURE(rc))

Note: See TracChangeset for help on using the changeset viewer.