Changeset 24644 in vbox for trunk/src

Timestamp:

Nov 13, 2009 4:32:46 PM (15 years ago)

Author:

vboxsync

Message:

Main: autolock was done too late in SetGuestProperty

File:

• trunk/src/VBox/Main/MachineImpl.cpp (modified) (2 diffs)

trunk/src/VBox/Main/MachineImpl.cpp

@@ -3518 +3518 @@
     try
     {
+        AutoCaller autoCaller(this);
+        CheckComRCReturnRC(autoCaller.rc());
+
+        AutoWriteLock alock(this);
+
+        rc = checkStateDependency(MutableStateDep);
+        CheckComRCReturnRC(rc);
+
+        rc = S_OK;
+
         Utf8Str utf8Name(aName);
         Utf8Str utf8Flags(aFlags);
@@ -3533 +3543 @@
                             tr("Invalid flag values: '%ls'"),
                             aFlags);
-
-        AutoCaller autoCaller(this);
-        CheckComRCReturnRC(autoCaller.rc());
-
-        AutoWriteLock alock(this);
-
-        rc = checkStateDependency(MutableStateDep);
-        CheckComRCReturnRC(rc);
-
-        rc = S_OK;
 
         if (!mHWData->mPropertyServiceActive)