Changeset 24661 in vbox for trunk

Timestamp:

Nov 14, 2009 11:37:32 PM (15 years ago)

Author:

vboxsync

Message:

review todo, not simple remark.

File:

• trunk/src/VBox/Runtime/common/string/strtonum.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/common/string/strtonum.cpp

@@ -109 +109 @@
  * @param   pu32        Where to store the converted number.
  *
- * @remarks The returned value isn't really suitable for comparing two version
- *          strings.  Try see which result you get when converting "3.0.14" and
- *          "3.1.0" and comparing the values.  The way to fix this deficiency
- *          would be to convert the individual parts and dividing the return
- *          value into sections: bits 31:24 FirstNumber; 23:16 Second; 15:8
- *          Third; 7:0 Forth.  It would probably be a good idea to use a 64-bit
- *          return value instead of a 32-bit one, so there is room for revision
- *          number when found.
+ * @todo    r=bird: The returned value isn't really suitable for comparing two
+ *          version strings.  Try see which result you get when converting
+ *          "3.0.14" and "3.1.0" and comparing the values.  The way to fix this
+ *          deficiency would be to convert the individual parts and dividing the
+ *          return value into sections: bits 31:24 FirstNumber; 23:16 Second;
+ *          15:8 Third; 7:0 Forth.  It would probably be a good idea to use a
+ *          64-bit return value instead of a 32-bit one, so there is room for
+ *          revision number when found.
  *
  *          Actually, because of the above, the kind of API I had in mind was