Changeset 24737 in vbox for trunk/src/VBox/Frontends/VirtualBox

Timestamp:

Nov 17, 2009 8:19:09 PM (15 years ago)

Author:

vboxsync

Message:

FE/Qt4: Snapshot Details Dialog: Preserving aspect ratio for initially opened screen-shot, supporting situation when screen-shot is not available but thumbnail is.

Location:

trunk/src/VBox/Frontends/VirtualBox

Files:

• include/VBoxSnapshotDetailsDlg.h (modified) (1 diff)
• src/VBoxSnapshotDetailsDlg.cpp (modified) (4 diffs)
• ui/VBoxSnapshotDetailsDlg.ui (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/include/VBoxSnapshotDetailsDlg.h

@@ -59 +59 @@
 
     QPixmap mThumbnail;
+    QPixmap mScreenshot;
 };
 

trunk/src/VBox/Frontends/VirtualBox/src/VBoxSnapshotDetailsDlg.cpp

@@ -69 +69 @@
     /* Get thumbnail if present */
     ULONG width = 0, height = 0;
-    QVector <BYTE> data = machine.ReadSavedThumbnailToArray (true, width, height);
-    mThumbnail = data.size() != 0 ? QPixmap::fromImage (QImage (data.data(), width, height, QImage::Format_RGB32).copy()) : QPixmap();
+    QVector <BYTE> thumbData = machine.ReadSavedThumbnailToArray (true, width, height);
+    mThumbnail = thumbData.size() != 0 ? QPixmap::fromImage (QImage (thumbData.data(), width, height, QImage::Format_RGB32).copy()) : QPixmap();
+    QVector <BYTE> screenData = machine.ReadSavedScreenshotPNGToArray (width, height);
+    mScreenshot = screenData.size() != 0 ? QPixmap::fromImage (QImage::fromData (screenData.data(), screenData.size(), "PNG")) : QPixmap();
+
     QGridLayout *lt = qobject_cast <QGridLayout*> (layout());
     Assert (lt);
@@ -118 +121 @@
     setWindowTitle (tr ("Details of %1 (%2)").arg (mSnapshot.GetName()).arg (machine.GetName()));
 
+    mLbThumbnail->setToolTip (mScreenshot.isNull() ? QString() : tr ("Click to enlarge the screenshot."));
+
     mTeDetails->setText (vboxGlobal().detailsReport (machine, false /* with links? */));
 }
@@ -124 +129 @@
 {
     Assert (aObject == mLbThumbnail);
-    if (aEvent->type() == QEvent::MouseButtonPress)
-    {
-        CMachine machine = mSnapshot.GetMachine();
-
-        ULONG width = 0, height = 0;
-        QVector <BYTE> data = machine.ReadSavedScreenshotPNGToArray (width, height);
-        Assert (data.size());
-        QPixmap pixmap = QPixmap::fromImage (QImage::fromData (data.data(), data.size(), "PNG"));
-
-        VBoxScreenshotViewer *viewer = new VBoxScreenshotViewer (this, pixmap, machine.GetName(), mSnapshot.GetName());
+    if (aEvent->type() == QEvent::MouseButtonPress && !mScreenshot.isNull())
+    {
+        VBoxScreenshotViewer *viewer = new VBoxScreenshotViewer (this, mScreenshot, mSnapshot.GetMachine().GetName(), mSnapshot.GetName());
         viewer->show();
     }
@@ -175 +173 @@
     layout->addWidget (mArea);
 
+    double aspectRatio = (double) aScreenshot.height() / aScreenshot.width();
     QSize maxSize = aScreenshot.size() + QSize (mArea->frameWidth() * 2, mArea->frameWidth() * 2);
-    QSize initSize = QSize (640, 480).boundedTo (maxSize);
+    QSize initSize = QSize (640, 640 * aspectRatio).boundedTo (maxSize);
 
     setMaximumSize (maxSize);

trunk/src/VBox/Frontends/VirtualBox/ui/VBoxSnapshotDetailsDlg.ui

@@ -62 +62 @@
       </sizepolicy>
      </property>
-     <property name="toolTip">
-      <string>Click to enlarge the screenshot.</string>
-     </property>
      <property name="frameShape">
       <enum>QFrame::Panel</enum>