Changeset 24745 in vbox for trunk

Timestamp:

Nov 17, 2009 10:34:09 PM (15 years ago)

Author:

vboxsync

Message:

DevATA: Async reset handling, protect reset or we'll die.

File:

• trunk/src/VBox/Devices/Storage/DevATA.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/Storage/DevATA.cpp

@@ -5287 +5287 @@
 
 /**
+ * Callback employed by ataSuspend and ataPowerOff.
+ *
+ * @returns true if we've quiesced, false if we're still working.
+ * @param   pDevIns     The device instance.
+ */
+static DECLCALLBACK(bool) ataR3IsAsyncResetDone(PPDMDEVINS pDevIns)
+{
+    PCIATAState *pThis = PDMINS_2_DATA(pDevIns, PCIATAState *);
+
+    if (   !ataWaitForAsyncIOIsIdle(&pThis->aCts[0], 1, true /*fLeaveSignallingOn*/)
+        || !ataWaitForAsyncIOIsIdle(&pThis->aCts[1], 1, true /*fLeaveSignallingOn*/))
+        return false;
+
+    for (uint32_t i = 0; i < RT_ELEMENTS(pThis->aCts); i++)
+    {
+        PDMCritSectEnter(&pThis->aCts[i].lock, VERR_INTERNAL_ERROR);
+        for (uint32_t j = 0; j < RT_ELEMENTS(pThis->aCts[i].aIfs); j++)
+            ataResetDevice(&pThis->aCts[i].aIfs[j]);
+        PDMCritSectLeave(&pThis->aCts[i].lock);
+    }
+    PDMDevHlpAsyncNotificationCompleted(pDevIns);
+    return true;
+}
+
+
+/**
  * Reset notification.
  *
@@ -5298 +5324 @@
     for (uint32_t i = 0; i < RT_ELEMENTS(pThis->aCts); i++)
     {
+        PDMCritSectEnter(&pThis->aCts[i].lock, VERR_INTERNAL_ERROR);
+
         pThis->aCts[i].iSelectedIf = 0;
         pThis->aCts[i].iAIOIf = 0;
@@ -5315 +5343 @@
         ataAsyncIOPutRequest(&pThis->aCts[i], &ataResetARequest);
         ataAsyncIOPutRequest(&pThis->aCts[i], &ataResetCRequest);
-/** @todo Deadlock alert. see @bugref{4394}. */
-        if (!ataWaitForAsyncIOIsIdle(&pThis->aCts[i], 30000, false /*fLeaveSignallingOn*/))
-        {
-            PDMDevHlpVMSetRuntimeError(pDevIns, 0 /*fFlags*/, "DevATA_ASYNCBUSY",
-                                       N_("The IDE async I/O thread remained busy after a reset, usually a host filesystem performance problem\n"));
-            AssertMsgFailed(("Async I/O thread busy after reset\n"));
-        }
-
-        for (uint32_t j = 0; j < RT_ELEMENTS(pThis->aCts[i].aIfs); j++)
-            ataResetDevice(&pThis->aCts[i].aIfs[j]);
-    }
+
+        PDMCritSectLeave(&pThis->aCts[i].lock);
+    }
+
+    /*
+     * Only reset the devices when both threads have quiesced.
+     */
+    if (   ataWaitForAsyncIOIsIdle(&pThis->aCts[0], 2, true /*fLeaveSignallingOn*/)
+        && ataWaitForAsyncIOIsIdle(&pThis->aCts[1], 2, true /*fLeaveSignallingOn*/))
+        for (uint32_t i = 0; i < RT_ELEMENTS(pThis->aCts); i++)
+        {
+            PDMCritSectEnter(&pThis->aCts[i].lock, VERR_INTERNAL_ERROR);
+            for (uint32_t j = 0; j < RT_ELEMENTS(pThis->aCts[i].aIfs); j++)
+                ataResetDevice(&pThis->aCts[i].aIfs[j]);
+            PDMCritSectLeave(&pThis->aCts[i].lock);
+        }
+    else
+        PDMDevHlpSetAsyncNotification(pDevIns, ataR3IsAsyncResetDone);
 }