Changeset 24778 in vbox for trunk

Timestamp:

Nov 19, 2009 9:25:29 AM (15 years ago)

Author:

vboxsync

Message:

Storage/VMDK: mostly cosmetic change to the code which writes VMDK extent descriptors. The spec explicitly says that only flat extents can have offsets. Neither our VMDK code nor any other had problems with our previous behavior, but that's no reason for subtly violating the specs.

File:

• trunk/src/VBox/Devices/Storage/VmdkHDDCore.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Storage/VmdkHDDCore.cpp

@@ -1683 +1683 @@
                     cNominalSectors, apszType[enmType]);
     }
+    else if (enmType == VMDKETYPE_FLAT)
+    {
+        RTStrPrintf(szExt, sizeof(szExt), "%s %llu %s \"%s\" %llu",
+                    apszAccess[enmAccess], cNominalSectors,
+                    apszType[enmType], pszBasename, uSectorOffset);
+    }
     else
     {
-        if (!uSectorOffset)
-            RTStrPrintf(szExt, sizeof(szExt), "%s %llu %s \"%s\"",
-                        apszAccess[enmAccess], cNominalSectors,
-                        apszType[enmType], pszBasename);
-        else
-            RTStrPrintf(szExt, sizeof(szExt), "%s %llu %s \"%s\" %llu",
-                        apszAccess[enmAccess], cNominalSectors,
-                        apszType[enmType], pszBasename, uSectorOffset);
+        RTStrPrintf(szExt, sizeof(szExt), "%s %llu %s \"%s\"",
+                    apszAccess[enmAccess], cNominalSectors,
+                    apszType[enmType], pszBasename);
     }
     cbDiff = strlen(szExt) + 1;