Changeset 25005 in vbox for trunk/src/VBox/Additions/common/VBoxGuestLib

Timestamp:

Nov 26, 2009 2:42:59 PM (15 years ago)

Author:

vboxsync

Message:

IPRT: Optimized version of RTStrVersionCompare (thanks to Knut!), made it behave like strcmp().

File:

• trunk/src/VBox/Additions/common/VBoxGuestLib/VBoxGuestR3LibHostVersion.cpp (modified) (1 diff)

trunk/src/VBox/Additions/common/VBoxGuestLib/VBoxGuestR3LibHostVersion.cpp

@@ -133 +133 @@
     if (RT_SUCCESS(rc) && *pfUpdate)
     {
-        uint8_t u8Res;
-        rc = RTStrVersionCompare(*ppszHostVersion, *ppszGuestVersion, &u8Res);
-        if (RT_FAILURE(rc))
-            LogFlow(("Error while comparing host versions! %s <-> %s, rc = %Rrc\n",
-                *ppszHostVersion, *ppszGuestVersion, rc));
-
-        if (u8Res == 1) /* Is host version greater than guest add version? */
+        if (RTStrVersionCompare(*ppszHostVersion, *ppszGuestVersion) == 1) /* Is host version greater than guest add version? */
         {
             /* Yay, we have an update! */