Changeset 25032 in vbox

Timestamp:

Nov 27, 2009 1:23:24 AM (15 years ago)

Author:

vboxsync

Message:

GuestProperties/service.cpp: Don't increment an iterator that has been passed to .erase(), it's invalid according to Visual C++. (Don't be afraid of using 'break'.)

File:

• trunk/src/VBox/HostServices/GuestProperties/service.cpp (modified) (1 diff)

trunk/src/VBox/HostServices/GuestProperties/service.cpp

@@ -477 +477 @@
         ++itEnd;
         for (unsigned i = 0; ppNames[i] != NULL; ++i)
-        {
-            bool found = false;
-            for (PropertyList::iterator it = mProperties.begin();
-                !found && it != itEnd; ++it)
+            for (PropertyList::iterator it = mProperties.begin(); it != itEnd; ++it)
                 if (it->mName.compare(ppNames[i]) == 0)
                 {
-                    found = true;
                     mProperties.erase(it);
+                    break;
                 }
-        }
     }