Changeset 25033 in vbox

Timestamp:

Nov 27, 2009 1:35:26 AM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

55355

Message:

PerformanceImpl.cpp: r=bird: marked what looks like an invalid std::list::erase use.

Location:

trunk/src/VBox/Main

Files:

• Makefile.kmk (modified) (1 diff)
• PerformanceImpl.cpp (modified) (2 diffs)

trunk/src/VBox/Main/Makefile.kmk

@@ -457 +457 @@
 
 
-if defined(VBOX_WITH_CROGL) || defined(VBOX_WITH_VIDEOHWACCEL)
+if (defined(VBOX_WITH_CROGL) || defined(VBOX_WITH_VIDEOHWACCEL)) && !defined(VBOX_WITH_DEBUG_VCC_CRT)
  ifneq ($(KBUILD_TARGET),darwin)
   #
   # VBoxTestOGL - OpenGL support test app.
+  # Note! Doesn't link with VBOX_WITH_DEBUG_VCC_CRT defined because it uses Qt.
   #
   ifdef VBOX_WITH_VIDEOHWACCEL

trunk/src/VBox/Main/PerformanceImpl.cpp

@@ -494 +494 @@
         if ((*it)->associatedWith(aObject))
         {
+            /** @todo r=bird: This looks dodgy and needs to be tested with a VBOX_WITH_DEBUG_VCC_CRT. How to reproduce? */
             delete *it;
             m.baseMetrics.erase(it++);
@@ -515 +516 @@
         if ((*it)->associatedWith(aObject))
         {
+            /** @todo r=bird: This looks dodgy and needs to be tested with a VBOX_WITH_DEBUG_VCC_CRT. How to reproduce? */
             delete *it;
             m.metrics.erase(it++);