Changeset 25201 in vbox for trunk/src/VBox/Main/include

Timestamp:

Dec 4, 2009 6:52:36 PM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

55682

Message:

Main: make BIOSSettings instance data private and make it use the XML settings struct for simplicity

File:

• trunk/src/VBox/Main/include/BIOSSettingsImpl.h (modified) (3 diffs)

trunk/src/VBox/Main/include/BIOSSettingsImpl.h

@@ -42 +42 @@
 {
 public:
-
-    struct Data
-    {
-        Data()
-        {
-            mLogoFadeIn = true;
-            mLogoFadeOut = true;
-            mLogoDisplayTime = 0;
-            mBootMenuMode = BIOSBootMenuMode_MessageAndMenu;
-            mACPIEnabled = true;
-            mIOAPICEnabled = false;
-            mPXEDebugEnabled = false;
-            mTimeOffset = 0;
-        }
-
-        bool operator== (const Data &that) const
-        {
-            return this == &that ||
-                   (mLogoFadeIn         == that.mLogoFadeIn &&
-                    mLogoFadeOut        == that.mLogoFadeOut &&
-                    mLogoDisplayTime    == that.mLogoDisplayTime &&
-                    mLogoImagePath      == that.mLogoImagePath &&
-                    mBootMenuMode       == that.mBootMenuMode &&
-                    mACPIEnabled        == that.mACPIEnabled &&
-                    mIOAPICEnabled      == that.mIOAPICEnabled &&
-                    mPXEDebugEnabled    == that.mPXEDebugEnabled &&
-                    mTimeOffset         == that.mTimeOffset);
-        }
-
-        BOOL                mLogoFadeIn;
-        BOOL                mLogoFadeOut;
-        ULONG               mLogoDisplayTime;
-        Bstr                mLogoImagePath;
-        BIOSBootMenuMode_T  mBootMenuMode;
-        BOOL                mACPIEnabled;
-        BOOL                mIOAPICEnabled;
-        BOOL                mPXEDebugEnabled;
-        LONG64              mTimeOffset;
-    };
-
     DECLARE_NOT_AGGREGATABLE(BIOSSettings)
 
@@ -125 +85 @@
     HRESULT saveSettings(settings::BIOSSettings &data);
 
-    bool isModified() { AutoWriteLock alock (this); return mData.isBackedUp(); }
-    bool isReallyModified() { AutoWriteLock alock (this); return mData.hasActualChanges(); }
-    void rollback() { AutoWriteLock alock (this); mData.rollback(); }
+    bool isModified();
+    bool isReallyModified();
+    void rollback();
     void commit();
     void copyFrom (BIOSSettings *aThat);
@@ -136 +96 @@
 
 private:
-
-    ComObjPtr<Machine, ComWeakRef> mParent;
-    ComObjPtr<BIOSSettings> mPeer;
-    Backupable<Data> mData;
+    struct Data;
+    Data *m;
 };