Changeset 255 in vbox

Timestamp:

Jan 23, 2007 9:33:50 PM (18 years ago)

Author:

vboxsync

Message:

same magic with caps lock

Location:

trunk

Files:

• include/VBox/pdm.h (modified) (1 diff)
• src/VBox/Frontends/VBoxSDL/VBoxSDL.cpp (modified) (3 diffs)
• src/VBox/Frontends/VirtualBox/include/VBoxConsoleView.h (modified) (1 diff)
• src/VBox/Frontends/VirtualBox/src/VBoxConsoleView.cpp (modified) (10 diffs)
• src/VBox/Main/include/DisplayImpl.h (modified) (1 diff)

trunk/include/VBox/pdm.h

@@ -593 +593 @@
     /** Num Lock */
     PDMKEYBLEDS_NUMLOCK          = 0x0001,
+    /** Caps Lock */
+    PDMKEYBLEDS_CAPSLOCK         = 0x0002,
     /** Scroll Lock */
-    PDMKEYBLEDS_SCROLLLOCK       = 0x0002,
-    /** Caps Lock */
-    PDMKEYBLEDS_CAPSLOCK         = 0x0004
+    PDMKEYBLEDS_SCROLLLOCK       = 0x0004
 } PDMKEYBLEDS;
 

trunk/src/VBox/Frontends/VBoxSDL/VBoxSDL.cpp

@@ -166 +166 @@
 static BOOL gfGuestScrollLockPressed = FALSE;
 static int  guGuestNumLockAdaptionCnt = 2;
+static int  guGuestCapsLockAdaptionCnt = 2;
 
 /** modifier keypress status (scancode as index) */
@@ -462 +463 @@
     }
 
-    STDMETHOD(OnKeyboardLedsChange)(BOOL fNumLock, BOOL fScrollLock, BOOL fCapsLock)
+    STDMETHOD(OnKeyboardLedsChange)(BOOL fNumLock, BOOL fCapsLock, BOOL fScrollLock)
     {
         /* Don't bother the guest with NumLock scancodes if he doesn't set the NumLock LED */
         if (gfGuestNumLockPressed != fNumLock)
             guGuestNumLockAdaptionCnt = 2;
+        if (gfGuestCapsLockPressed != fCapsLock)
+            guGuestCapsLockAdaptionCnt = 2;
         gfGuestNumLockPressed    = fNumLock;
+        gfGuestCapsLockPressed   = fCapsLock;
         gfGuestScrollLockPressed = fScrollLock;
-        gfGuestCapsLockPressed   = fCapsLock;
         return S_OK;
     }
@@ -2793 +2796 @@
     }
 
-    /*
-     * Some keyboards (e.g. the one of mine T60) don't send a NumLock scan code on every
-     * press of the key. Both the guest and the host should agree on the NumLock state.
-     * If they differ, we try to alter the guest NumLock state by sending the NumLock key
-     * scancode. We will get a feedback through the KBD_CMD_SET_LEDS command if the guest
-     * tries to set/clear the NumLock LED. If a (silly) guest doesn't change the LED, don't
-     * bother him with NumLock scancodes. At least our BIOS, Linux and Windows handle the
-     * NumLock LED well.
-     */
-    if (   guGuestNumLockAdaptionCnt
-        && (gfGuestNumLockPressed ^ !!(SDL_GetModState() & KMOD_NUM)))
-    {
-        guGuestNumLockAdaptionCnt--;
-        gKeyboard->PutScancode(0x45);
-        gKeyboard->PutScancode(0x45 | 0x80);
+    if (ev->type != SDL_KEYDOWN)
+    {
+        /*
+         * Some keyboards (e.g. the one of mine T60) don't send a NumLock scan code on every
+         * press of the key. Both the guest and the host should agree on the NumLock state.
+         * If they differ, we try to alter the guest NumLock state by sending the NumLock key
+         * scancode. We will get a feedback through the KBD_CMD_SET_LEDS command if the guest
+         * tries to set/clear the NumLock LED. If a (silly) guest doesn't change the LED, don't
+         * bother him with NumLock scancodes. At least our BIOS, Linux and Windows handle the
+         * NumLock LED well.
+         */
+        if (   guGuestNumLockAdaptionCnt
+            && (gfGuestNumLockPressed ^ !!(SDL_GetModState() & KMOD_NUM)))
+        {
+            guGuestNumLockAdaptionCnt--;
+            gKeyboard->PutScancode(0x45);
+            gKeyboard->PutScancode(0x45 | 0x80);
+        }
+#if 0  /* For some reason SDL_GetModState() does not return KMOD_CAPS correctly */
+        if (   guGuestCapsLockAdaptionCnt
+            && (gfGuestCapsLockPressed ^ !!(SDL_GetModState() & KMOD_CAPS)))
+        {
+            guGuestCapsLockAdaptionCnt--;
+            gKeyboard->PutScancode(0x3a);
+            gKeyboard->PutScancode(0x3a | 0x80);
+        }
+#endif
     }
 

trunk/src/VBox/Frontends/VirtualBox/include/VBoxConsoleView.h

@@ -200 +200 @@
     bool mfCapsLock;
     long muNumLockAdaptionCnt;
+    long muCapsLockAdaptionCnt;
 
     QTimer *resize_hint_timer;

trunk/src/VBox/Frontends/VirtualBox/src/VBoxConsoleView.cpp

@@ -198 +198 @@
 {
 public:
-    ModifierKeyChangeEvent(bool fNumLock, bool fScrollLock, bool fCapsLock) :
+    ModifierKeyChangeEvent(bool fNumLock, bool fCapsLock, bool fScrollLock) :
         QEvent ((QEvent::Type) VBoxDefs::ModifierKeyChangeEventType),
-        mfNumLock(fNumLock), mfScrollLock(fScrollLock), mfCapsLock(fCapsLock) {}
+        mfNumLock(fNumLock), mfCapsLock(fCapsLock), mfScrollLock(fScrollLock) {}
     bool NumLock()    const { return mfNumLock; }
+    bool CapsLock()   const { return mfCapsLock; }
     bool ScrollLock() const { return mfScrollLock; }
-    bool CapsLock()   const { return mfCapsLock; }
 private:
-    bool mfNumLock, mfScrollLock, mfCapsLock;
+    bool mfNumLock, mfCapsLock, mfScrollLock;
 };
 
@@ -292 +292 @@
     }
 
-    STDMETHOD(OnKeyboardLedsChange)(BOOL fNumLock, BOOL fScrollLock, BOOL fCapsLock)
+    STDMETHOD(OnKeyboardLedsChange)(BOOL fNumLock, BOOL fCapsLock, BOOL fScrollLock)
     {
         QApplication::postEvent (
-            view, new ModifierKeyChangeEvent (fNumLock, fScrollLock, fCapsLock));
+            view, new ModifierKeyChangeEvent (fNumLock, fCapsLock, fScrollLock));
         return S_OK;
     }
@@ -350 +350 @@
     , autoresize_guest (false)
     , muNumLockAdaptionCnt (2)
+    , muCapsLockAdaptionCnt (2)
     , mode (rm)
 {
@@ -784 +785 @@
                 if (me->NumLock() != mfNumLock)
                     muNumLockAdaptionCnt = 2;
+                if (me->CapsLock() != mfCapsLock)
+                    muCapsLockAdaptionCnt = 2;
                 mfNumLock    = me->NumLock();
+                mfCapsLock   = me->CapsLock();
                 mfScrollLock = me->ScrollLock();
-                mfCapsLock   = me->CapsLock();
                 return true;
             }
@@ -1289 +1292 @@
 void VBoxConsoleView::FixModifierState(LONG *codes, uint *count)
 {
-    unsigned uKeyMaskNum = 0, uKeyMaskCaps = 0, uKeyMaskScroll = 0;
-
 #if defined(Q_WS_X11)
 
@@ -1296 +1297 @@
     int      iDummy3, iDummy4, iDummy5, iDummy6;
     unsigned uMask;
+    unsigned uKeyMaskNum = 0, uKeyMaskCaps = 0, uKeyMaskScroll = 0;
 
     uKeyMaskCaps          = LockMask;
@@ -1321 +1323 @@
         codes[(*count)++] = 0x45 | 0x80;
     }
+    if (muCapsLockAdaptionCnt && (mfCapsLock ^ !!(uMask & uKeyMaskCaps)))
+    {
+        muCapsLockAdaptionCnt--;
+        codes[(*count)++] = 0x3a;
+        codes[(*count)++] = 0x3a | 0x80;
+    }
 
 #elif defined(Q_WS_WIN32)
@@ -1329 +1337 @@
         codes[(*count)++] = 0x45;
         codes[(*count)++] = 0x45 | 0x80;
+    }
+    if (muCapsLockAdaptionCnt && (mfCapsLock ^ !!(GetKeyState(VK_CAPITAL))))
+    {
+        muCapsLockAdaptionCnt--;
+        codes[(*count)++] = 0x3a;
+        codes[(*count)++] = 0x3a | 0x80;
     }
 
@@ -1388 +1402 @@
         else
         {
+            if (flags & KeyPressed)
+            {
+                // Check if the guest has the same view on the modifier keys (NumLock,
+                // CapsLock, ScrollLock) as the X server. If not, send KeyPress events
+                // to synchronize the state.
+                FixModifierState (codes, &count);
+            }
+
             // process the scancode and update the table of pressed keys
             uint8_t what_pressed = IsKeyPressed;
@@ -1415 +1437 @@
             else
                 keys_pressed [scan] &= ~IsKbdCaptured;
-
-            // Check if the guest has the same view on the modifier keys (NumLock,
-            // CapsLock, ScrollLock) as the X server. If not, send KeyPress events
-            // to synchronize the state.
-            FixModifierState (codes, &count);
-            
         }
     }

trunk/src/VBox/Main/include/DisplayImpl.h

@@ -97 +97 @@
     }
 
-    STDMETHOD(OnKeyboardLedsChange)(BOOL fNumLock, BOOL fScrollLock, BOOL fCapsLock)
+    STDMETHOD(OnKeyboardLedsChange)(BOOL fNumLock, BOOL fCapsLock, BOOL fScrollLock)
     {
         return S_OK;