Changeset 25551 in vbox for trunk/src/VBox/VMM/VMMAll

Timestamp:

Dec 21, 2009 5:22:45 PM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

56227

Message:

Removed the obsolete RC tlb flushing in the pgm pool access handler. Our disassembler can now deal with flushed tlb entries.
(watch for regressions!)

File:

• trunk/src/VBox/VMM/VMMAll/PGMAllPool.cpp (modified) (3 diffs)

trunk/src/VBox/VMM/VMMAll/PGMAllPool.cpp

@@ -908 +908 @@
         rc = rc2;
 
-#ifdef IN_RC
-    /* See use in pgmPoolAccessHandlerSimple(). */
-    PGM_INVL_VCPU_TLBS(pVCpu);
-#endif
     LogFlow(("pgmPoolAccessHandlerPT: returns %Rrc (flushed)\n", rc));
     return rc;
@@ -981 +977 @@
     pRegFrame->rip += pDis->opsize;
 
-#ifdef IN_RC
-    /* See use in pgmPoolAccessHandlerSimple(). */
-    PGM_INVL_VCPU_TLBS(pVCpu);
-#endif
-
     LogFlow(("pgmPoolAccessHandlerSTOSD: returns\n"));
     return VINF_SUCCESS;
@@ -1070 +1061 @@
         }
     }
-#endif
-
-#ifdef IN_RC
-    /*
-     * Quick hack, with logging enabled we're getting stale
-     * code TLBs but no data TLB for EIP and crash in EMInterpretDisasOne.
-     * Flushing here is BAD and expensive, I think EMInterpretDisasOne will
-     * have to be fixed to support this. But that'll have to wait till next week.
-     *
-     * An alternative is to keep track of the changed PTEs together with the
-     * GCPhys from the guest PT. This may proove expensive though.
-     *
-     * At the moment, it's VITAL that it's done AFTER the instruction interpreting
-     * because we need the stale TLBs in some cases (XP boot). This MUST be fixed properly!
-     */
-    PGM_INVL_VCPU_TLBS(pVCpu);
 #endif