Changeset 25563 in vbox for trunk/src/VBox/Additions/common

Timestamp:

Dec 22, 2009 12:59:20 PM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

56240

Message:

VBoxServiceTimeSync.cpp: r=bird: r56149 doesn't make sense, ditto for the identical check added in r55587.

File:

• trunk/src/VBox/Additions/common/VBoxService/VBoxServiceTimeSync.cpp (modified) (2 diffs)

trunk/src/VBox/Additions/common/VBoxService/VBoxServiceTimeSync.cpp

@@ -335 +335 @@
 {
 #ifdef RT_OS_WINDOWS
-/** @todo r=bird: NT4 doesn't have GetSystemTimeAdjustment. */
+/** @todo r=bird: NT4 doesn't have GetSystemTimeAdjustment according to MSDN. */
+/** @todo r=bird: g_hTokenProcess cannot be NULL here.
+ *        VBoxServiceTimeSyncInit will fail and the service will not be
+ *        started with it being NULL.  VBoxServiceTimeSyncInit OTOH will *NOT*
+ *        be called until the service thread has terminated.  If anything
+ *        else is the case, there is buggy code somewhere.*/
     if (g_hTokenProcess == NULL) /* Is the token already closed when shutting down? */
         return false;
@@ -411 +416 @@
 {
 #ifdef RT_OS_WINDOWS
+/** @todo r=bird: g_hTokenProcess cannot be NULL here.  See argumentation in
+ *        VBoxServiceTimeSyncAdjust.  */
     if (g_hTokenProcess == NULL) /* No process token (anymore)? */
         return;