Changeset 25708 in vbox

Timestamp:

Jan 11, 2010 10:14:35 AM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

56445

Message:

VBoxServiceUtils: Extended logging for VBoxServiceWritePropF().

File:

• trunk/src/VBox/Additions/common/VBoxService/VBoxServiceUtils.cpp (modified) (2 diffs)

trunk/src/VBox/Additions/common/VBoxService/VBoxServiceUtils.cpp

@@ -156 +156 @@
  * @param   pszName         The property name.
  * @param   pszValueFormat  The property format string.  If this is NULL then
- *                          the property will be removed.
+ *                          the property will be deleted (if possible).
  * @param   ...             Format arguments.
  */
 int VBoxServiceWritePropF(uint32_t u32ClientId, const char *pszName, const char *pszValueFormat, ...)
 {
+    AssertPtr(pszName);
     int rc;
     if (pszValueFormat != NULL)
     {
-        /** @todo Log the value as well? just copy the guts of
-         *        VbglR3GuestPropWriteValueV. */
-        VBoxServiceVerbose(3, "Writing guest property \"%s\"\n", pszName);
         va_list va;
         va_start(va, pszValueFormat);
+
+        char *pszValue = RTStrAPrintf2V(pszValueFormat, va);
+        AssertPtr(pszValue);
+        VBoxServiceVerbose(3, "Writing guest property \"%s\" = \"%s\"\n", pszName, pszValue);
+        RTStrFree(pszValue);
+
         rc = VbglR3GuestPropWriteValueV(u32ClientId, pszName, pszValueFormat, va);
         va_end(va);
@@ -176 +180 @@
     else
     {
+        VBoxServiceVerbose(3, "Deleting guest property \"%s\"\n", pszName);   
         rc = VbglR3GuestPropWriteValue(u32ClientId, pszName, NULL);
         if (RT_FAILURE(rc))
-            VBoxServiceError("Error removing guest property \"%s\" (rc=%Rrc)\n", pszName, rc);
+            VBoxServiceError("Error deleting guest property \"%s\" (rc=%Rrc)\n", pszName, rc);
     }
     return rc;