Changeset 25843 in vbox

Timestamp:

Jan 14, 2010 6:51:32 PM (15 years ago)

Author:

vboxsync

Message:

Main: fix deadlock candidates detected by lock validator

Location:

trunk/src/VBox/Main

Files:

• MachineImpl.cpp (modified) (6 diffs)
• MediumImpl.cpp (modified) (3 diffs)
• NetworkAdapterImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/MachineImpl.cpp

@@ -96 +96 @@
 
 Machine::Data::Data()
-    : mSnapshotsTreeLockHandle(LOCKCLASS_OTHERLIST)
+    : mSnapshotsTreeLockHandle(LOCKCLASS_MACHINELIST)
 {
     mRegistered = FALSE;
@@ -631 +631 @@
     LogFlowThisFunc(("mRegistered=%d\n", mData->mRegistered));
 
-    /* Enter this object lock because there may be a SessionMachine instance
-     * somewhere around, that shares our data and lock but doesn't use our
-     * addCaller()/removeCaller(), and it may be also accessing the same data
-     * members. mParent lock is necessary as well because of
-     * SessionMachine::uninit(), etc.
-     */
-    AutoMultiWriteLock2 alock(mParent, this COMMA_LOCKVAL_SRC_POS);
+    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
 
     if (!mData->mSession.mMachine.isNull())
@@ -653 +647 @@
          * still valid). We'll call it ourselves below.
          */
-        LogWarningThisFunc(("Session machine is not NULL (%p), "
-                             "the direct session is still open!\n",
-                             (SessionMachine *) mData->mSession.mMachine));
-
-        if (Global::IsOnlineOrTransient (mData->mMachineState))
+        LogWarningThisFunc(("Session machine is not NULL (%p), the direct session is still open!\n",
+                            (SessionMachine*)mData->mSession.mMachine));
+
+        if (Global::IsOnlineOrTransient(mData->mMachineState))
         {
             LogWarningThisFunc(("Setting state to Aborted!\n"));
             /* set machine state using SessionMachine reimplementation */
-            static_cast <Machine *> (mData->mSession.mMachine)
-                ->setMachineState (MachineState_Aborted);
+            static_cast<Machine*>(mData->mSession.mMachine)->setMachineState (MachineState_Aborted);
         }
 
@@ -671 +663 @@
         mData->mSession.mMachine->uninit();
         /* SessionMachine::uninit() must set mSession.mMachine to null */
-        Assert (mData->mSession.mMachine.isNull());
+        Assert(mData->mSession.mMachine.isNull());
     }
 
@@ -9741 +9733 @@
  *  filter for the given USB device and @c false otherwise.
  *
- *  @note Locks this object for reading.
+ *  @note Caller must have requested machine read lock.
  */
 bool SessionMachine::hasMatchingUSBFilter (const ComObjPtr<HostUSBDevice> &aDevice, ULONG *aMaskedIfs)
@@ -9751 +9743 @@
         return false;
 
-    AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
+    AssertReturn(isWriteLockOnCurrentThread(), false);
 
 #ifdef VBOX_WITH_USB

trunk/src/VBox/Main/MediumImpl.cpp

@@ -1256 +1256 @@
  *       uninit() methods.
  *
- * @note Locks getTreeLock() for writing, VirtualBox for writing.
+ * @note Caller must hold the tree lock of the medium tree this medium is on.
  */
 void Medium::uninit()
@@ -1281 +1281 @@
     else
     {
-        /* we uninit children and reset mParent
-         * and VirtualBox::removeDependentChild() needs a write lock */
-        AutoWriteLock alock1(m->pVirtualBox->lockHandle() COMMA_LOCKVAL_SRC_POS);
-        AutoWriteLock alock2(m->pVirtualBox->hardDiskTreeLockHandle() COMMA_LOCKVAL_SRC_POS);
-
         MediaList::iterator it;
         for (it = m->llChildren.begin();
@@ -3055 +3050 @@
     if (FAILED(autoCaller.rc())) return autoCaller.rc();
 
-    AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
-
     /* we access mParent */
     AutoReadLock treeLock(m->pVirtualBox->hardDiskTreeLockHandle() COMMA_LOCKVAL_SRC_POS);
+
+    AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
 
     data.uuid = m->id;

trunk/src/VBox/Main/NetworkAdapterImpl.cpp

@@ -906 +906 @@
     AutoCaller autoCaller(this);
     AssertComRCReturnRC(autoCaller.rc());
-
-    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
 
     /* Note: we assume that the default values for attributes of optional