Changeset 25913 in vbox

Timestamp:

Jan 19, 2010 12:58:00 PM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

56737

Message:

Main: fix missing cleanup of snapshots in Machine destructor (causes leak and misleading error messages when machine is inaccessible)

File:

• trunk/src/VBox/Main/MachineImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/MachineImpl.cpp

@@ -5787 +5787 @@
     if (getClassID() == clsidMachine)
     {
-        /* reset some important fields of mData */
+        // clean up the snapshots list (Snapshot::uninit() will handle the snapshot's children recursively)
+        if (mData->mFirstSnapshot)
+        {
+            mData->mFirstSnapshot->uninit();
+            mData->mFirstSnapshot.setNull();
+        }
+
         mData->mCurrentSnapshot.setNull();
-        mData->mFirstSnapshot.setNull();
     }