Changeset 25942 in vbox for trunk/src/VBox/Main/freebsd

Timestamp:

Jan 20, 2010 5:26:22 PM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

56784

Message:

*: RTEnv usage cleanup - avoid RTEnvGet() as it doesn't necessarily return UTF-8 encoded strings.

File:

• trunk/src/VBox/Main/freebsd/HostHardwareFreeBSD.cpp (modified) (3 diffs)

trunk/src/VBox/Main/freebsd/HostHardwareFreeBSD.cpp

@@ -341 +341 @@
     int rc = VINF_SUCCESS;
     bool success = false;
+    char *pszFreeMe = RTEnvDupEx(RTENV_DEFAULT, pcszVar);
 
     try
     {
-        const char *pcszCurrent = RTEnvGet (pcszVar);
+        const char *pcszCurrent = pszFreeMe;
         while (pcszCurrent && *pcszCurrent != '\0')
         {
@@ -357 +358 @@
             if (RT_SUCCESS(RTPathReal(szPath, szReal, sizeof(szReal))))
             {
+                szUdi[0] = '\0'; /** @todo r=bird: missing a call to devValidateDevice() here and szUdi wasn't
+                                  *        initialized because of that.  Need proper fixing. */
                 pList->push_back(DriveInfo(szReal, szUdi, szDesc));
                 success = true;
@@ -369 +372 @@
         rc = VERR_NO_MEMORY;
     }
-    LogFlowFunc (("rc=%Rrc, success=%d\n", rc, success));
+    RTStrFree(pszFreeMe);
+    LogFlowFunc(("rc=%Rrc, success=%d\n", rc, success));
     return rc;
 }