Changeset 26070 in vbox for trunk/src/VBox/Additions/common

Timestamp:

Jan 27, 2010 2:57:30 PM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

57001

Message:

Always clear the userInfo structure as we use unsafe strncpy operations on strings.

File:

• trunk/src/VBox/Additions/common/VBoxService/VBoxServiceVMInfo.cpp (modified) (1 diff)

trunk/src/VBox/Additions/common/VBoxService/VBoxServiceVMInfo.cpp

@@ -224 +224 @@
         DWORD dwNumOfProcLUIDs = VBoxServiceVMInfoWinGetLUIDsFromProcesses(&pLuid);
 
-        VBOXSERVICEVMINFOUSER userInfo;
-        ZeroMemory (&userInfo, sizeof(VBOXSERVICEVMINFOUSER));
-
         for (int i = 0; i<(int)ulCount; i++)
         {
+            VBOXSERVICEVMINFOUSER userInfo;
+            ZeroMemory (&userInfo, sizeof(VBOXSERVICEVMINFOUSER));
+
             if (VBoxServiceVMInfoWinIsLoggedIn(&userInfo, &pSessions[i], pLuid, dwNumOfProcLUIDs))
             {