Changeset 26084 in vbox

Timestamp:

Jan 28, 2010 1:59:20 PM (15 years ago)

Author:

vboxsync

Message:

Main: fix locking order violation when loading USB filters

File:

• trunk/src/VBox/Main/USBControllerImpl.cpp (modified) (2 diffs)

trunk/src/VBox/Main/USBControllerImpl.cpp

@@ -611 +611 @@
  *  @param aMachineNode <Machine> node.
  *
- *  @note Locks this object for writing.
+ *  @note Does not lock "this" as Machine::loadHardware, which calls this, does not lock either.
  */
 HRESULT USBController::loadSettings(const settings::USBController &data)
@@ -617 +617 @@
     AutoCaller autoCaller(this);
     AssertComRCReturnRC(autoCaller.rc());
-
-    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
 
     /* Note: we assume that the default values for attributes of optional