Changeset 26108 in vbox

Timestamp:

Jan 30, 2010 9:21:11 PM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

57094

Message:

AsyncCompletion: More statistics

Location:

trunk/src/VBox/VMM

Files:

• PDMAsyncCompletion.cpp (modified) (5 diffs)
• PDMAsyncCompletionInternal.h (modified) (3 diffs)

trunk/src/VBox/VMM/PDMAsyncCompletion.cpp

@@ -39 +39 @@
 #include <iprt/critsect.h>
 #include <iprt/tcp.h>
+#include <iprt/path.h>
 
 #include <VBox/pdmasynccompletion.h>
@@ -837 +838 @@
         pTask->pPrev     = NULL;
         pTask->pNext     = NULL;
+#ifdef VBOX_WITH_STATISTICS
+        pTask->tsNsStart = RTTimeNanoTS();
+        STAM_COUNTER_INC(&pEndpoint->StatIoOpsStarted);
+#endif
     }
 
@@ -853 +858 @@
 {
     PPDMASYNCCOMPLETIONEPCLASS pEndpointClass = pEndpoint->pEpClass;
+
+#ifdef VBOX_WITH_STATISTICS
+    uint64_t tsRun  = RTTimeNanoTS() - pTask->tsNsStart;
+    uint64_t iStatIdx;
+
+    if (tsRun < 1000)
+    {
+        /* Update nanoseconds statistics */
+        iStatIdx = tsRun / 100;
+        STAM_COUNTER_INC(&pEndpoint->StatTaskRunTimesNs[iStatIdx]);
+    }
+    else
+    {
+        tsRun /= 1000;
+
+        if (tsRun < 1000)
+        {
+            /* Update microsecnds statistics */
+            iStatIdx = tsRun / 100;
+            STAM_COUNTER_INC(&pEndpoint->StatTaskRunTimesMicroSec[iStatIdx]);
+        }
+        else
+        {
+            tsRun /= 1000;
+
+            if (tsRun < 1000)
+            {
+                /* Update milliseconds statistics */
+                iStatIdx = tsRun / 100;
+                STAM_COUNTER_INC(&pEndpoint->StatTaskRunTimesMs[iStatIdx]);
+            }
+            else
+            {
+                tsRun /= 1000;
+
+                if (tsRun < 1000)
+                {
+                    /* Update seconds statistics */
+                    iStatIdx = tsRun / 10;
+                    STAM_COUNTER_INC(&pEndpoint->StatTaskRunTimesSec[iStatIdx]);
+                }
+                else
+                    STAM_COUNTER_INC(&pEndpoint->StatTaskRunOver100Sec);
+            }
+        }
+    }
+
+    STAM_COUNTER_INC(&pEndpoint->StatIoOpsCompleted);
+    pEndpoint->cIoOpsCompleted++;
+    uint64_t tsMsCur = RTTimeMilliTS();
+    uint64_t tsInterval = tsMsCur - pEndpoint->tsIntervalStartMs;
+
+    if (tsInterval >= 1000)
+    {
+        pEndpoint->StatIoOpsPerSec.c = pEndpoint->cIoOpsCompleted / (tsInterval / 1000);
+        pEndpoint->tsIntervalStartMs = tsMsCur;
+        pEndpoint->cIoOpsCompleted = 0;
+    }
+#endif
 
     /* Check whether we can use the per endpoint cache */
@@ -947 +1011 @@
             pEndpoint->pszUri            = RTStrDup(pszFilename);
             pEndpoint->cUsers            = 1;
-            if (pEndpoint->pszUri)
+
+#ifdef VBOX_WITH_STATISTICS
+            /* Init the statistics part */
+            for (unsigned i = 0; i < RT_ELEMENTS(pEndpoint->StatTaskRunTimesNs); i++)
+            {
+                rc = STAMR3RegisterF(pVM, &pEndpoint->StatTaskRunTimesNs[i], STAMTYPE_COUNTER,
+                                     STAMVISIBILITY_USED,
+                                     STAMUNIT_OCCURENCES,
+                                     "Nanosecond resolution runtime statistics",
+                                     "/PDM/AsyncCompletion/File/%s/TaskRunNs-%u-%u",
+                                     RTPathFilename(pEndpoint->pszUri),
+                                     i*100, i*100+100-1);
+                if (RT_FAILURE(rc))
+                    break;
+            }
+
+            if (RT_SUCCESS(rc))
+            {
+                for (unsigned i = 0; i < RT_ELEMENTS(pEndpoint->StatTaskRunTimesMicroSec); i++)
+                {
+                    rc = STAMR3RegisterF(pVM, &pEndpoint->StatTaskRunTimesMicroSec[i], STAMTYPE_COUNTER,
+                                         STAMVISIBILITY_USED,
+                                         STAMUNIT_OCCURENCES,
+                                         "Microsecond resolution runtime statistics",
+                                         "/PDM/AsyncCompletion/File/%s/TaskRunMicroSec-%u-%u",
+                                         RTPathFilename(pEndpoint->pszUri),
+                                        i*100, i*100+100-1);
+                    if (RT_FAILURE(rc))
+                        break;
+                }
+            }
+
+            if (RT_SUCCESS(rc))
+            {
+                for (unsigned i = 0; i < RT_ELEMENTS(pEndpoint->StatTaskRunTimesMs); i++)
+                {
+                    rc = STAMR3RegisterF(pVM, &pEndpoint->StatTaskRunTimesMs[i], STAMTYPE_COUNTER,
+                                         STAMVISIBILITY_USED,
+                                         STAMUNIT_OCCURENCES,
+                                         "Milliseconds resolution runtime statistics",
+                                         "/PDM/AsyncCompletion/File/%s/TaskRunMs-%u-%u",
+                                         RTPathFilename(pEndpoint->pszUri),
+                                        i*100, i*100+100-1);
+                    if (RT_FAILURE(rc))
+                        break;
+                }
+            }
+
+            if (RT_SUCCESS(rc))
+            {
+                for (unsigned i = 0; i < RT_ELEMENTS(pEndpoint->StatTaskRunTimesMs); i++)
+                {
+                    rc = STAMR3RegisterF(pVM, &pEndpoint->StatTaskRunTimesSec[i], STAMTYPE_COUNTER,
+                                         STAMVISIBILITY_USED,
+                                         STAMUNIT_OCCURENCES,
+                                         "Second resolution runtime statistics",
+                                         "/PDM/AsyncCompletion/File/%s/TaskRunSec-%u-%u",
+                                         RTPathFilename(pEndpoint->pszUri),
+                                        i*10, i*10+10-1);
+                    if (RT_FAILURE(rc))
+                        break;
+                }
+            }
+
+            if (RT_SUCCESS(rc))
+            {
+                rc = STAMR3RegisterF(pVM, &pEndpoint->StatTaskRunOver100Sec, STAMTYPE_COUNTER,
+                                     STAMVISIBILITY_USED,
+                                     STAMUNIT_OCCURENCES,
+                                     "Tasks which ran more than 100sec",
+                                     "/PDM/AsyncCompletion/File/%s/TaskRunSecGreater100Sec",
+                                     RTPathFilename(pEndpoint->pszUri));
+            }
+
+            if (RT_SUCCESS(rc))
+            {
+                rc = STAMR3RegisterF(pVM, &pEndpoint->StatIoOpsPerSec, STAMTYPE_COUNTER,
+                                     STAMVISIBILITY_ALWAYS,
+                                     STAMUNIT_OCCURENCES,
+                                     "Processed I/O operations per second",
+                                     "/PDM/AsyncCompletion/File/%s/IoOpsPerSec",
+                                     RTPathFilename(pEndpoint->pszUri));
+            }
+
+            if (RT_SUCCESS(rc))
+            {
+                rc = STAMR3RegisterF(pVM, &pEndpoint->StatIoOpsStarted, STAMTYPE_COUNTER,
+                                     STAMVISIBILITY_ALWAYS,
+                                     STAMUNIT_OCCURENCES,
+                                     "Started I/O operations for this endpoint",
+                                     "/PDM/AsyncCompletion/File/%s/IoOpsStarted",
+                                     RTPathFilename(pEndpoint->pszUri));
+            }
+
+            if (RT_SUCCESS(rc))
+            {
+                rc = STAMR3RegisterF(pVM, &pEndpoint->StatIoOpsCompleted, STAMTYPE_COUNTER,
+                                     STAMVISIBILITY_ALWAYS,
+                                     STAMUNIT_OCCURENCES,
+                                     "Completed I/O operations for this endpoint",
+                                     "/PDM/AsyncCompletion/File/%s/IoOpsCompleted",
+                                     RTPathFilename(pEndpoint->pszUri));
+            }
+
+            pEndpoint->tsIntervalStartMs = RTTimeMilliTS();
+#endif
+
+            if (   pEndpoint->pszUri
+                && RT_SUCCESS(rc))
             {
                 /* Init the cache. */
@@ -1053 +1225 @@
         AssertMsg(RT_SUCCESS(rc), ("Failed to enter critical section rc=%Rrc\n", rc));
 
+#ifdef VBOX_WITH_STATISTICS
+        /* Deregister the statistics part */
+        PVM pVM = pEndpointClass->pVM;
+
+        for (unsigned i = 0; i < RT_ELEMENTS(pEndpoint->StatTaskRunTimesNs); i++)
+            STAMR3Deregister(pVM, &pEndpoint->StatTaskRunTimesNs[i]);
+        for (unsigned i = 0; i < RT_ELEMENTS(pEndpoint->StatTaskRunTimesMicroSec); i++)
+            STAMR3Deregister(pVM, &pEndpoint->StatTaskRunTimesMicroSec[i]);
+        for (unsigned i = 0; i < RT_ELEMENTS(pEndpoint->StatTaskRunTimesMs); i++)
+            STAMR3Deregister(pVM, &pEndpoint->StatTaskRunTimesMs[i]);
+        for (unsigned i = 0; i < RT_ELEMENTS(pEndpoint->StatTaskRunTimesMs); i++)
+            STAMR3Deregister(pVM, &pEndpoint->StatTaskRunTimesSec[i]);
+
+        STAMR3Deregister(pVM, &pEndpoint->StatTaskRunOver100Sec);
+        STAMR3Deregister(pVM, &pEndpoint->StatIoOpsPerSec);
+        STAMR3Deregister(pVM, &pEndpoint->StatIoOpsStarted);
+        STAMR3Deregister(pVM, &pEndpoint->StatIoOpsCompleted);
+#endif
+
         RTStrFree(pEndpoint->pszUri);
         MMR3HeapFree(pEndpoint);

trunk/src/VBox/VMM/PDMAsyncCompletionInternal.h

@@ -27 +27 @@
 #include <VBox/types.h>
 #include <VBox/cfgm.h>
+#include <VBox/stam.h>
 #include <VBox/pdmasynccompletion.h>
 
@@ -226 +227 @@
     /** URI describing the endpoint */
     char                                       *pszUri;
+#ifdef VBOX_WITH_STATISTICS
+    STAMCOUNTER                                 StatTaskRunTimesNs[10];
+    STAMCOUNTER                                 StatTaskRunTimesMicroSec[10];
+    STAMCOUNTER                                 StatTaskRunTimesMs[10];
+    STAMCOUNTER                                 StatTaskRunTimesSec[10];
+    STAMCOUNTER                                 StatTaskRunOver100Sec;
+    STAMCOUNTER                                 StatIoOpsPerSec;
+    STAMCOUNTER                                 StatIoOpsStarted;
+    STAMCOUNTER                                 StatIoOpsCompleted;
+    uint64_t                                    tsIntervalStartMs;
+    uint64_t                                    cIoOpsCompleted;
+#endif
 } PDMASYNCCOMPLETIONENDPOINT;
 
@@ -246 +259 @@
     /** Task id. */
     uint32_t                                uTaskId;
+#ifdef VBOX_WITH_STATISTICS
+    /** Start timestamp. */
+    uint64_t                                tsNsStart;
+#endif
 } PDMASYNCCOMPLETIONTASK;