Changeset 26167 in vbox for trunk/src/VBox/Main/AudioAdapterImpl.cpp

Timestamp:

Feb 2, 2010 7:59:09 PM (15 years ago)

Author:

vboxsync

Message:

Main: get rid of isModified() loops in Machine and subclasses; instead, on every change in machine settings, set dirty bits in Machine

File:

• trunk/src/VBox/Main/AudioAdapterImpl.cpp (modified) (4 diffs)

trunk/src/VBox/Main/AudioAdapterImpl.cpp

@@ -205 +205 @@
         mData.backup();
         mData->mEnabled = aEnabled;
+
+        alock.release();
+        AutoWriteLock mlock(mParent COMMA_LOCKVAL_SRC_POS);  // mParent is const, needs no locking
+        mParent->setModified(Machine::IsModified_AudioAdapter);
     }
 
@@ -279 +283 @@
                 mData.backup();
                 mData->mAudioDriver = aAudioDriver;
+
+                alock.release();
+                AutoWriteLock mlock(mParent COMMA_LOCKVAL_SRC_POS);  // mParent is const, needs no locking
+                mParent->setModified(Machine::IsModified_AudioAdapter);
                 break;
             }
@@ -330 +338 @@
             case AudioControllerType_AC97:
             case AudioControllerType_SB16:
+            {
                 mData.backup();
                 mData->mAudioController = aAudioController;
+
+                alock.release();
+                AutoWriteLock mlock(mParent COMMA_LOCKVAL_SRC_POS);  // mParent is const, needs no locking
+                mParent->setModified(Machine::IsModified_AudioAdapter);
                 break;
+            }
 
             default:
-            {
                 AssertMsgFailed (("Wrong audio controller type %d\n",
                                   aAudioController));
                 rc = E_FAIL;
-            }
         }
     }
@@ -414 +426 @@
 }
 
-bool AudioAdapter::isModified()
-{
-    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
-    return mData.isBackedUp();
-}
-
 /**
  *  @note Locks this object for writing.