Changeset 26395 in vbox for trunk/src/VBox

Timestamp:

Feb 9, 2010 6:08:24 PM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

57490

Message:

Web service: use multi event sems or else no parallel processing

File:

• trunk/src/VBox/Main/webservice/vboxweb.cpp (modified) (5 diffs)

trunk/src/VBox/Main/webservice/vboxweb.cpp ¶

@@ -269 +269 @@
           m_cIdleThreads(0)
     {
-        RTSemEventCreate(&m_event);
+        RTSemEventMultiCreate(&m_event);
 
         // create cThreads threads
@@ -292 +292 @@
     ~SoapQ()
     {
-        RTSemEventDestroy(m_event);
+        RTSemEventMultiDestroy(m_event);
     }
 
     util::WriteLockHandle   m_mutex;
-    RTSEMEVENT              m_event;
+    RTSEMEVENTMULTI         m_event;
 
     std::list<SoapThread*>  m_llAllThreads;
@@ -314 +314 @@
     {
         // wait for something to happen
-        RTSemEventWait(pst->pQ->m_event, RT_INDEFINITE_WAIT);
+        RTSemEventMultiWait(pst->pQ->m_event, RT_INDEFINITE_WAIT);
 
         util::AutoWriteLock qlock(pst->pQ->m_mutex COMMA_LOCKVAL_SRC_POS);
@@ -322 +322 @@
             pst->pQ->m_llSocketsQ.pop_front();
             --pst->pQ->m_cIdleThreads;
+
+            // reset the multi event only if the queue is now empty; otherwise
+            // another thread will also wake up when we release the mutex and
+            // process another one
+            if (pst->pQ->m_llSocketsQ.size() == 0)
+                RTSemEventMultiReset(pst->pQ->m_event);
+
             qlock.release();
 
@@ -398 +405 @@
             WebLog("Request %llu on socket %d queued for processing\n", i, s);
             // unblock one of the worker threads
-            RTSemEventSignal(soapq.m_event);
+            RTSemEventMultiSignal(soapq.m_event);
 
             // we have to process main event queue