Changeset 2661 in vbox for trunk/src

Timestamp:

May 16, 2007 11:48:06 AM (18 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

21207

Message:

Raw disk access VMDKs can now be generated, too.

File:

• trunk/src/VBox/Devices/Storage/VmdkHDDCore.cpp (modified) (11 diffs)

trunk/src/VBox/Devices/Storage/VmdkHDDCore.cpp

@@ -295 +295 @@
     /** Image type. */
     VDIMAGETYPE     enmImageType;
+    /** Image flags defined during creation or determined during open. */
+    unsigned        uImageFlags;
     /** Total size of the image. */
     uint64_t        cbSize;
@@ -478 +480 @@
     size_t cbGTRounded;
     uint64_t cbOverhead;
-    
+
     if (fPreAlloc)
         cbGTRounded = RT_ALIGN_64(pExtent->cGDEntries * pExtent->cGTEntries * sizeof(uint32_t), 512);
@@ -587 +589 @@
 }
 
-static int vmdkDescInitStr(PVMDKIMAGE pImage, PVMDKDESCRIPTOR pDescriptor, 
+static int vmdkDescInitStr(PVMDKIMAGE pImage, PVMDKDESCRIPTOR pDescriptor,
                            const char *pszLine)
 {
@@ -1044 +1046 @@
     if (VBOX_FAILURE(rc))
         goto out;
-    rc = vmdkDescInitStr(pImage, pDescriptor, "# DDB");
+    rc = vmdkDescInitStr(pImage, pDescriptor, "#DDB");
     if (VBOX_FAILURE(rc))
         goto out;
@@ -1566 +1568 @@
         RTFileClose(pExtent->File);
         pExtent->File = NIL_RTFILE;
-        if (fDelete && pExtent->pszFullname)
+        if (    fDelete
+            &&  strcmp(pExtent->pszFullname, pExtent->pszBasename) != 0
+            && pExtent->pszFullname)
             RTFileDelete(pExtent->pszFullname);
     }
@@ -1663 +1667 @@
         goto out;
     }
+
+    /** @todo set up pImage->uImageFlags accordingly somewhere during open. */
 
     /* Handle the file according to its magic number. */
@@ -1884 +1890 @@
 }
 
-static int vmdkCreateImage(PVMDKIMAGE pImage, const char *pszFilename, VDIMAGETYPE enmType, uint64_t cbSize, unsigned uImageFlags, uint32_t cCylinders, uint32_t cHeads, uint32_t cSectors)
+static int vmdkCreateImage(PVMDKIMAGE pImage, const char *pszFilename, VDIMAGETYPE enmType, uint64_t cbSize, unsigned uImageFlags, const char *pszComment, uint32_t cCylinders, uint32_t cHeads, uint32_t cSectors)
 {
     int rc;
@@ -1890 +1896 @@
     PVMDKEXTENT pExtent;
 
+    pImage->uImageFlags = uImageFlags;
     rc = vmdkCreateDescriptor(pImage, pImage->pDescData, pImage->cbDescAlloc, &pImage->Descriptor);
     if (VBOX_FAILURE(rc))
@@ -1898 +1905 @@
 
     if (    enmType == VD_IMAGE_TYPE_FIXED
-        ||  uImageFlags == VD_VMDK_IMAGE_FLAGS_SPLIT_2G)
+        ||  (uImageFlags & VD_VMDK_IMAGE_FLAGS_SPLIT_2G)
+        ||  (uImageFlags & VD_VMDK_IMAGE_FLAGS_RAWDISK))
     {
         /* Fixed images and split images in general have a separate descriptor
          * file. This is the more complicated case, as it requires setting up
          * potentially more than one extent, including filename generation. */
-        rc = VERR_NOT_IMPLEMENTED;
-        goto out;
+
+        if (    enmType == VD_IMAGE_TYPE_FIXED
+            &&  (uImageFlags & VD_VMDK_IMAGE_FLAGS_RAWDISK))
+        {
+            PVBOXHDDRAW pRaw = (PVBOXHDDRAW)(void *)pszComment;
+            if (pRaw->fRawDisk)
+            {
+                /* Full raw disk access. This requires setting up a descriptor
+                 * file and open the (flat) raw disk. */
+                rc = vmdkCreateExtents(pImage, 1);
+                if (VBOX_FAILURE(rc))
+                {
+                    rc = vmdkError(pImage, rc, RT_SRC_POS, N_("VMDK: could not create new extent list in '%s'"), pszFilename);
+                    goto out;
+                }
+                pExtent = &pImage->pExtents[0];
+                rc = RTFileOpen(&pImage->File, pszFilename,
+                                RTFILE_O_READWRITE | RTFILE_O_CREATE | RTFILE_O_DENY_WRITE);
+                if (VBOX_FAILURE(rc))
+                {
+                    rc = vmdkError(pImage, rc, RT_SRC_POS, N_("VMDK: could not create new file '%s'"), pszFilename);
+                    goto out;
+                }
+
+                /* Set up basename for extent description. Cannot use StrDup. */
+                size_t cbBasename = strlen(pRaw->pszRawDisk) + 1;
+                char *pszBasename = (char *)RTMemTmpAlloc(cbBasename);
+                if (!pszBasename)
+                {
+                    rc = VERR_NO_MEMORY;
+                    goto out;
+                }
+                memcpy(pszBasename, pRaw->pszRawDisk, cbBasename);
+                pExtent->pszBasename = pszBasename;
+                /* For raw disks the full name is identical to the base name. */
+                pExtent->pszFullname = RTStrDup(pszBasename);
+                if (!pExtent->pszFullname)
+                {
+                    rc = VERR_NO_MEMORY;
+                    goto out;
+                }
+                pExtent->enmType = VMDKETYPE_FLAT;
+                pExtent->cNominalSectors = VMDK_BYTE2SECTOR(cbSize);
+                pExtent->uSectorOffset = 0;
+                pExtent->enmAccess = VMDKACCESS_READWRITE;
+                pExtent->fMetaDirty = true;
+
+                pImage->enmImageType = enmType;
+                rc = vmdkDescSetStr(pImage, &pImage->Descriptor, pImage->Descriptor.uFirstDesc, "createType", "\"fullDevice\"");
+                if (VBOX_FAILURE(rc))
+                {
+                    rc = vmdkError(pImage, rc, RT_SRC_POS, N_("VMDK: could not set the image type in '%s'"), pszFilename);
+                    goto out;
+                }
+
+                /* Open flat image, the raw disk. */
+                rc = RTFileOpen(&pExtent->File, pExtent->pszFullname,
+                                RTFILE_O_READWRITE | RTFILE_O_OPEN | RTFILE_O_DENY_WRITE);
+                if (VBOX_FAILURE(rc))
+                {
+                    rc = vmdkError(pImage, rc, RT_SRC_POS, N_("VMDK: could not open raw disk file '%s'"), pExtent->pszFullname);
+                    goto out;
+                }
+            }
+            else
+            {
+                /******* fixme. */
+                rc = VERR_NOT_IMPLEMENTED;
+                goto out;
+            }
+        }
+        else
+        {
+            rc = VERR_NOT_IMPLEMENTED;
+            goto out;
+        }
     }
     else
@@ -1917 +1999 @@
         pExtent = &pImage->pExtents[0];
         pImage->File = NIL_RTFILE;
-        rc = RTFileOpen(&pExtent->File, pszFilename, 
+        rc = RTFileOpen(&pExtent->File, pszFilename,
                         RTFILE_O_READWRITE | RTFILE_O_CREATE | RTFILE_O_DENY_WRITE);
         if (VBOX_FAILURE(rc))
@@ -2468 +2550 @@
 
     rc = vmdkCreateImage(pImage, pszFilename, enmType, cbSize, uImageFlags,
-                         cCylinders, cHeads, cSectors);
+                         pszComment, cCylinders, cHeads, cSectors);
     if (VBOX_SUCCESS(rc))
     {