Changeset 26918 in vbox

Timestamp:

Mar 1, 2010 3:03:04 PM (15 years ago)

Author:

vboxsync

Message:

Additions/win: fixed off-by-one error when deflating the memory balloon

File:

• trunk/src/VBox/Additions/WINNT/VBoxGuest/VBoxGuest.cpp (modified) (3 diffs)

trunk/src/VBox/Additions/WINNT/VBoxGuest/VBoxGuest.cpp

@@ -562 +562 @@
     VMMDevChangeMemBalloon *req = NULL;
     int rc = VINF_SUCCESS;
+    uint32_t i;
 
     if (u32BalloonSize > pDevExt->MemBalloon.cMaxBalloons)
@@ -580 +581 @@
     {
         /* inflate */
-        for (uint32_t i=pDevExt->MemBalloon.cBalloons;i<u32BalloonSize;i++)
+        for (i = pDevExt->MemBalloon.cBalloons; i < u32BalloonSize; i++)
         {
 #ifndef TARGET_NT4
@@ -675 +676 @@
     {
         /* deflate */
-        for (uint32_t _i = pDevExt->MemBalloon.cBalloons - 1; _i > u32BalloonSize; _i--)
-        {
-            uint32_t index = _i - 1;
+        for (i = pDevExt->MemBalloon.cBalloons; i > u32BalloonSize; i--)
+        {
+            uint32_t index = i - 1;
             PMDL  pMdl = pDevExt->MemBalloon.paMdlMemBalloon[index];