Changeset 2700 in vbox for trunk/src

Timestamp:

May 17, 2007 3:34:02 PM (18 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

21279

Message:

Full-screen and maximization issues fixed. Current implementation:

1. In case of auto-resize feature is on: VBox window returns to previous dimensions then going normal mode after leaving Full-screen or Maximized modes.
2. In case of auto-resize feature is off: VBox tries to adjust window dimensions to guest dimensions if necessary then going normal mode after leaving Full-screen or Maximized modes.

Guest additions event handler implemented and used for:

1. Guest Addition outdated version detection. User will be warned about outdated additions.
2. Auto-resize feature enabling. This feature will be disabled in the dropped down menu until additions-state-change event notifies vbox about guest additions activation.

Location:

trunk/src/VBox/Frontends/VirtualBox

Files:

• include/VBoxConsoleView.h (modified) (3 diffs)
• include/VBoxConsoleWnd.h (modified) (2 diffs)
• include/VBoxDefs.h (modified) (1 diff)
• src/VBoxConsoleView.cpp (modified) (13 diffs)
• src/VBoxConsoleWnd.cpp (modified) (7 diffs)

trunk/src/VBox/Frontends/VirtualBox/include/VBoxConsoleView.h

@@ -49 +49 @@
 class QMenuData;
 
+/** Auto-resize event.
+  * Useful for posting into events queue to be processed just after all
+  * QEvent::Resize & QEvent::WindowStateChange events currently posted.
+  * This is necessary due to these two events - QEvent::Resize &
+  * QEvent::WindowStateChange are processed in different sequence
+  * under Win32 and X11. */
+class AutoResizeEvent : public QEvent
+{
+public:
+    AutoResizeEvent () :
+        QEvent ((QEvent::Type) VBoxDefs::AutoResizeEventType) {}
+};
+
 class VBoxConsoleView : public QScrollView
 {
@@ -96 +109 @@
     void mouseStateChanged (int state);
     void machineStateChanged (CEnums::MachineState state);
+    void additionsStateChanged (const QString &, bool);
 
 protected:
@@ -169 +183 @@
     static void dimImage (QImage &img);
 
+    void performAutoResize();
+
 private slots:
 
     void doResizeHint();
-    void normalizeGeo() { normalizeGeometry(); }
+    void normalizeGeo() { normalizeGeometry (true); }
 
 private:

trunk/src/VBox/Frontends/VirtualBox/include/VBoxConsoleWnd.h

@@ -160 +160 @@
     void updateMouseState (int state);
 
+    void updateAdditionsState (const QString&, bool);
+
     void tryClose();
 
@@ -246 +248 @@
 
     CSession csession;
+
+    bool mIsAutoresizeEnabled;
 
     // widgets

trunk/src/VBox/Frontends/VirtualBox/include/VBoxDefs.h

@@ -128 +128 @@
         MousePointerChangeEventType,
         MachineStateChangeEventType,
+        AdditionsStateChangeEventType,
+        AutoResizeEventType,
         MachineDataChangeEventType,
         MachineRegisteredEventType,

trunk/src/VBox/Frontends/VirtualBox/src/VBoxConsoleView.cpp

@@ -225 +225 @@
 };
 
+/** Guest Additions property changes. */
+class GuestAdditionsEvent : public QEvent
+{
+public:
+    GuestAdditionsEvent (const QString &aOsTypeId,
+                         const QString &aAddVersion,
+                         bool aAddActive) :
+        QEvent ((QEvent::Type) VBoxDefs::AdditionsStateChangeEventType),
+        mOsTypeId (aOsTypeId), mAddVersion (aAddVersion), mAddActive (aAddActive) {}
+    const QString &osTypeId() const { return mOsTypeId; }
+    const QString &additionVersion() const { return mAddVersion; }
+    bool additionActive() const { return mAddActive; }
+private:
+    QString mOsTypeId;
+    QString mAddVersion;
+    bool mAddActive;
+};
+
 /** Menu activation event */
 class ActivateMenuEvent : public QEvent
@@ -352 +370 @@
                       guest.GetAdditionsVersion().latin1(),
                       guest.GetAdditionsActive()));
-        /** @todo */
+        QApplication::postEvent (mView,
+                                 new GuestAdditionsEvent (
+                                     guest.GetOSTypeId(),
+                                     guest.GetAdditionsVersion(),
+                                     guest.GetAdditionsActive()));
         return S_OK;
     }
@@ -811 +833 @@
             case VBoxDefs::ResizeEventType:
             {
+                bool old_ignore_mainwnd_resize = ignore_mainwnd_resize;
                 ignore_mainwnd_resize = true;
 
@@ -842 +865 @@
                  * full screen */
                 if (!mainwnd->isTrueFullscreen() &&
-                    !topLevelWidget()->isMaximized() &&
-                    !resize_hint_timer->isActive())
+                    !topLevelWidget()->isMaximized())
                     normalizeGeometry (true /* adjustPosition */);
 
@@ -849 +871 @@
                 cconsole.GetDisplay().ResizeCompleted();
 
-                ignore_mainwnd_resize = false;
+                ignore_mainwnd_resize = old_ignore_mainwnd_resize;
 
                 return true;
@@ -912 +934 @@
                 onStateChange (me->machineState());
                 emit machineStateChanged (me->machineState());
+                return true;
+            }
+
+            case VBoxDefs::AdditionsStateChangeEventType:
+            {
+                GuestAdditionsEvent *ge = (GuestAdditionsEvent *) e;
+                LogFlowFunc (("AdditionsStateChangeEventType\n"));
+                emit additionsStateChanged (ge->additionVersion(), ge->additionActive());
                 return true;
             }
@@ -1004 +1034 @@
             }
 
+            case VBoxDefs::AutoResizeEventType:
+            {
+                performAutoResize();
+                return true;
+            }
+
             default:
                 break;
@@ -1105 +1141 @@
                     if (autoresize_guest)
                         resize_hint_timer->start (300, TRUE);
+                    /* During window maximization WindowStateChange event is
+                     * processed before Resize event, so the ignore_mainwnd_resize
+                     * variable should be set to true here in case of mainwnd is
+                     * maximized or in fullscreen state. */
+                    if (mainwnd->isMaximized() || mainwnd->isTrueFullscreen())
+                        ignore_mainwnd_resize = true;
                 }
                 break;
@@ -1110 +1152 @@
             case QEvent::WindowStateChange:
             {
-                if (!mainwnd->isMinimized())
-                {
-                    if (!mainwnd->isMaximized())
-                    {
-                        /* The guest screen size (and therefore the contents
-                         * size) could have been changed while we were maximized
-                         * or minimized, so normalize the main window size
-                         * unless we're in true fullscreen mode. Calling
-                         * normalizeGeometry() directly from here doesn't work
-                         * for some reason, so use a single shot timer. */
-                        if (!mainwnd->isTrueFullscreen())
-                            QTimer::singleShot (0, this, SLOT (normalizeGeo()));
-                    }
-                }
+                /* The guest screen size (and therefore the contents size)
+                 * could have been changed while we were maximized or minimized,
+                 * so posting event for auto-resize and normalization. */
+                if (!mainwnd->isMinimized() &&
+                    !mainwnd->isMaximized() &&
+                    !mainwnd->isTrueFullscreen())
+                    QApplication::postEvent (this, new AutoResizeEvent ());
             }
 
@@ -1483 +1518 @@
         m_darwinKeyModifiers = newMask;
 
-        /* Always return true here because we'll otherwise getting a Qt event 
+        /* Always return true here because we'll otherwise getting a Qt event
            we don't want and that will only cause the Pause warning to pop up. */
         ret = true;
@@ -1671 +1706 @@
 
 
+}
+
+void VBoxConsoleView::performAutoResize()
+{
+    if (autoresize_guest)
+    {
+        doResizeHint();
+        QTimer::singleShot (200, this, SLOT (normalizeGeo()));
+    }
+    else
+    {
+        normalizeGeo();
+    }
+    ignore_mainwnd_resize = false;
 }
 
@@ -2452 +2501 @@
     // Note, that it's just a guess that sending RESEND will give the desired
     // effect :), but at least it works with NT and W2k guests.
-    /** @todo This seems to causes linux guests (in console mode) to cough a bit. 
+    /** @todo This seems to causes linux guests (in console mode) to cough a bit.
      * We need to check if this is the cause of #1944 and/or #1949. --bird */
     codes [0] = 0xFE;
@@ -2477 +2526 @@
     m_darwinKeyModifiers &= alphaLock | kEventKeyModifierNumLockMask
                           | (release_hostkey ? 0 : ::DarwinKeyCodeToDarwinModifierMask (gs.hostKey()));
-#endif 
+#endif
 
     emitKeyboardStateChanged ();

trunk/src/VBox/Frontends/VirtualBox/src/VBoxConsoleWnd.cpp

@@ -57 +57 @@
 #include <qtimer.h>
 
+#include <VBox/VBoxGuest.h>
+#define VBOX_GUEST_ADDITIONS_VERSION_OK(additionsVersion) \
+        (RT_HIWORD(additionsVersion) == RT_HIWORD(VMMDEV_VERSION) && \
+         RT_LOWORD(additionsVersion) <= RT_LOWORD(VMMDEV_VERSION))
+
 #if defined(Q_WS_X11)
 #include <X11/Xlib.h>
@@ -214 +219 @@
     , dbgMenu (NULL)
 #endif
+    , mIsAutoresizeEnabled (false)
     , console (0)
     , mUsbLedTip (0)
@@ -268 +274 @@
         VBoxGlobal::iconSet ("auto_resize_on_16px.png", "auto_resize_on_disabled_16px.png"));
     vmAutoresizeGuestAction->setToggleAction (true);
+    vmAutoresizeGuestAction->setEnabled (false);
 
     vmAdjustWindowAction = new QAction (this, "vmAdjustWindowAction");
@@ -722 +729 @@
         str = cmachine.GetExtraData (GUI_AutoresizeGuest);
         if (str != "off")
-            vmAutoresizeGuestAction->setOn (true);
+            mIsAutoresizeEnabled = true;
 
         str = cmachine.GetExtraData (GUI_LastWindowPosition);
@@ -825 +832 @@
     connect (console, SIGNAL (machineStateChanged (CEnums::MachineState)),
              this, SLOT (updateMachineState (CEnums::MachineState)));
+    connect (console, SIGNAL (additionsStateChanged (const QString&, bool)),
+             this, SLOT (updateAdditionsState (const QString &, bool)));
 
 #ifdef Q_WS_MAC
@@ -1782 +1791 @@
         if (was_max)
             setWindowState (windowState() | WindowMaximized);
+        QApplication::postEvent (console, new AutoResizeEvent());
     }
 
@@ -2493 +2503 @@
 }
 
+
+void VBoxConsoleWnd::updateAdditionsState (const QString &aVersion, bool aActive)
+{
+    /* mIsAutoresizeEnabled flag stores the auto-resize status loaded from the
+     * settings and used for the activation of the autoresize feature
+     * if the additions state told us here it is activated. */
+    vmAutoresizeGuestAction->setEnabled (aActive);
+    vmAutoresizeGuestAction->setOn (aActive && mIsAutoresizeEnabled);
+
+    /* Checking for the Guest Additions version to warn user about possible
+     * compatibility issues in case of installed version is outdated. */
+    uint version = aVersion.toUInt();
+    bool isVersionOk = VBOX_GUEST_ADDITIONS_VERSION_OK (version);
+    if (!isVersionOk)
+        vboxProblem().message (this, VBoxProblemReporter::Warning,
+            tr ("<p>Current Guest Additions version is outdated. Please install "
+                "the latest version to avoid compatibility issues.</p>"));
+}
+
 /**
  *  Helper to safely close the main console window.