Changeset 27126 in vbox for trunk/include

Timestamp:

Mar 5, 2010 7:40:43 PM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

58461

Message:

PIT,RTC,HPET,PDM: Combined and simplified the two interfaces PDM uses to inform PIT & RTC about HPET legacy mode changes. Moved the code to the right places in the files. Use bool, not uint8_t, when we mean boolean (no saved state difference).

Location:

trunk/include/VBox

Files:

• pdmdev.h (modified) (1 diff)
• pdmifs.h (modified) (1 diff)

trunk/include/VBox/pdmdev.h

@@ -1711 +1711 @@
      * @returns rc if we failed to set legacy mode.
      * @param   pDevIns         Device instance of the HPET.
-     * @param   fActivate       Activate or deactivate legacy mode.
-     */
-    DECLR3CALLBACKMEMBER(int, pfnSetLegacyMode,(PPDMDEVINS pDevIns, bool fActivate));
+     * @param   fActivated      Whether legacy mode is activated or deactivated.
+     */
+    DECLR3CALLBACKMEMBER(int, pfnSetLegacyMode,(PPDMDEVINS pDevIns, bool fActivated));
 
 

trunk/include/VBox/pdmifs.h

@@ -1937 +1937 @@
 #define PDMIVMMDEVPORT_IID                      "d7e52035-3b6c-422e-9215-2a75646a945d"
 
-/** Pointer to a PIT port interface. */
-typedef struct PDMIPITPORT *PPDMIPITPORT;
-/**
- * PIT port interface.
- */
-typedef struct PDMIPITPORT
-{
-    /**
-     * Notify PIT about change of HPET legacy mode.
-     *
-     * @returns VBox status code
-     * @param   pInterface      Pointer to the interface structure containing the called function pointer.
-     * @param   fActivate       If HPET legacy mode activated or deactivated.
-     */
-    DECLR3CALLBACKMEMBER(int, pfnNotifyHpetLegacy,(PPDMIPITPORT pInterface, bool fActivate));
-} PDMIPITPORT;
-/** PDMIPITPORT interface ID. */
-#define PDMIPITPORT_IID                        "06127207-3182-4394-b16e-0ecfeb5cbb27"
-
-/** Pointer to a RTC port interface. */
-typedef struct PDMIRTCPORT *PPDMIRTCPORT;
-/**
- * RTC port interface.
- */
-typedef struct PDMIRTCPORT
-{
-    /**
-     * Notify RTC about change of HPET legacy mode.
-     *
-     * @returns VBox status code
-     * @param   pInterface      Pointer to the interface structure containing the called function pointer.
-     * @param   fActivate       If HPET legacy mode activated or deactivated.
-     */
-    DECLR3CALLBACKMEMBER(int, pfnNotifyHpetLegacy,(PPDMIRTCPORT pInterface, bool fActivate));
-} PDMIRTCPORT;
-/** PDMIRTCPORT interface ID. */
-#define PDMIRTCPORT_IID                        "b6af0d7c-56c7-4064-85aa-ba78b43a26e7"
+
+/** Pointer to a HPET legacy notifcation interface. */
+typedef struct PDMIHPETLEGACYNOTIFY *PPDMIHPETLEGACYNOTIFY;
+/**
+ * HPET legacy notifcation interface.
+ */
+typedef struct PDMIHPETLEGACYNOTIFY
+{
+    /**
+     * Notify about change of HPET legacy mode.
+     *
+     * @param   pInterface      Pointer to the interface structure containing the
+     *                          called function pointer.
+     * @param   fActivated      If HPET legacy mode is activated (@c true) or
+     *                          deactivated (@c false).
+     */
+    DECLR3CALLBACKMEMBER(void, pfnModeChanged,(PPDMIHPETLEGACYNOTIFY pInterface, bool fActivated));
+} PDMIHPETLEGACYNOTIFY;
+/** PDMIHPETLEGACYNOTIFY interface ID. */
+#define PDMIHPETLEGACYNOTIFY_IID                "c9ada595-4b65-4311-8b21-b10498997774"